third_party/WebKit/public/platform/WebPointerProperties.h - Issue 2624783002: Fix movementX/Y attributes for touch pointer events

Side by Side Diff: third_party/WebKit/public/platform/WebPointerProperties.h

Issue 2624783002: Fix movementX/Y attributes for touch pointer events (Closed)

Patch Set: Initialize m_frameScale in PointerEventFactoryTest Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« content/browser/renderer_host/render_widget_host_view_base.cc ('K') | « third_party/WebKit/public/platform/WebMouseEvent.h ('k') | ui/events/blink/blink_event_util.cc » ('j') | ui/events/blink/blink_event_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef WebPointerProperties_h	5 #ifndef WebPointerProperties_h

6 #define WebPointerProperties_h	6 #define WebPointerProperties_h

7	7

8 #include <cstdint>	8 #include <cstdint>

9 #include <limits>	9 #include <limits>

10	10

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
75 // is the neutral position of the control. Always 0 if the device does not	75 // is the neutral position of the control. Always 0 if the device does not

76 // support it.	76 // support it.

77 float tangentialPressure;	77 float tangentialPressure;

78	78

79 // The clockwise rotation of a pen stylus around its own major axis, in	79 // The clockwise rotation of a pen stylus around its own major axis, in

80 // degrees in the range [0,359]. Always 0 if the device does not support it.	80 // degrees in the range [0,359]. Always 0 if the device does not support it.

81 int twist;	81 int twist;

82	82

83 Button button;	83 Button button;

84 PointerType pointerType;	84 PointerType pointerType;

	85

	86 int movementX;
	Rick Byers 2017/02/06 22:00:53 nit: add a comment saying what co-ordinate space t nit: add a comment saying what co-ordinate space this is in Navid Zolghadr 2017/02/07 15:58:51 I'm not sure there is any answer for this. Dave ad Show quoted text On 2017/02/06 22:00:53, Rick Byers wrote: > nit: add a comment saying what co-ordinate space this is in I'm not sure there is any answer for this. Dave added a m_frameScale variable in WebInputEvent which scales this coordinates in movementInRootFrame function https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/WebMo.... I added the same in WebTouchEvent in this CL. So these will be transformed when they get to blink. So I believe they will have different meaning? Also I don't know what different coordinate spaces are called before or after transformations. Rick Byers 2017/02/08 21:45:14 Ugh, right. That makes it hard to reason about al Show quoted text On 2017/02/07 15:58:51, Navid Zolghadr wrote: > On 2017/02/06 22:00:53, Rick Byers wrote: > > nit: add a comment saying what co-ordinate space this is in > > I'm not sure there is any answer for this. Dave added a m_frameScale variable in > WebInputEvent which scales this coordinates in movementInRootFrame function > https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/WebMo.... > I added the same in WebTouchEvent in this CL. > > So these will be transformed when they get to blink. So I believe they will have > different meaning? Also I don't know what different coordinate spaces are called > before or after transformations. Ugh, right. That makes it hard to reason about all these co-ordinates (movementX/Y is the least of our potential confusion here). Ok ignore this for now. Maybe later we can add some comments better describing the co-ordinate system for all of the WebTouchEvent/WebMouseEvent co-ordinates. FWIW the official documentation is here: https://www.chromium.org/developers/design-documents/blink-coordinate-spaces
	87 int movementY;

85 };	88 };

86	89

87 } // namespace blink	90 } // namespace blink

88	91

89 #endif	92 #endif

OLD	NEW