[ignition] Use Smis directly for type feedback

src/code-stub-assembler.h

Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index be527fa8d30bee06dd8050de27e78315b28853d9..99e4412d3f719afd9433f8cc7698278b1706ea36 100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -233,6 +233,17 @@ class V8_EXPORT_PRIVATE CodeStubAssembler : public compiler::CodeAssembler {
   Node* SelectBooleanConstant(Node* condition);
   Node* SelectTaggedConstant(Node* condition, Node* true_value,
                              Node* false_value);
+  Node* SelectSmiConstant(Node* condition, Smi* true_value, Smi* false_value);

[rmcilroy, 2017/01/10 15:05:50]

nit - I would prefer just to have the Smi version of this function and always do
Smi::FromInt explicitly in the caller.

[Leszek Swirski, 2017/01/11 10:10:03]

I'd rather keep this as is, for consistency with SmiConstant, and since the
whole point is to be a convenience method (currently used in 9 places). I could
move the implementations to .cc though?

+  Node* SelectSmiConstant(Node* condition, int true_value, Smi* false_value) {
+    return SelectSmiConstant(condition, Smi::FromInt(true_value), false_value);
+  }
+  Node* SelectSmiConstant(Node* condition, Smi* true_value, int false_value) {
+    return SelectSmiConstant(condition, true_value, Smi::FromInt(false_value));
+  }
+  Node* SelectSmiConstant(Node* condition, int true_value, int false_value) {
+    return SelectSmiConstant(condition, Smi::FromInt(true_value),
+                             Smi::FromInt(false_value));
+  }
 
   Node* TruncateWordToWord32(Node* value);