[ignition] Use Smis directly for type feedback

src/code-stub-assembler.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODE_STUB_ASSEMBLER_H_
 #define V8_CODE_STUB_ASSEMBLER_H_
 
 #include <functional>
 
 #include "src/compiler/code-assembler.h"
@@ skipping 215 matching lines @@
                const NodeGenerator& false_body, MachineRepresentation rep);
 
   Node* SelectConstant(Node* condition, Node* true_value, Node* false_value,
                        MachineRepresentation rep);
 
   Node* SelectInt32Constant(Node* condition, int true_value, int false_value);
   Node* SelectIntPtrConstant(Node* condition, int true_value, int false_value);
   Node* SelectBooleanConstant(Node* condition);
   Node* SelectTaggedConstant(Node* condition, Node* true_value,
                              Node* false_value);
+  Node* SelectSmiConstant(Node* condition, Smi* true_value, Smi* false_value);

[rmcilroy, 2017/01/10 15:05:50]

nit - I would prefer just to have the Smi version of this function and always do
Smi::FromInt explicitly in the caller.

[Leszek Swirski, 2017/01/11 10:10:03]

I'd rather keep this as is, for consistency with SmiConstant, and since the
whole point is to be a convenience method (currently used in 9 places). I could
move the implementations to .cc though?

+  Node* SelectSmiConstant(Node* condition, int true_value, Smi* false_value) {
+    return SelectSmiConstant(condition, Smi::FromInt(true_value), false_value);
+  }
+  Node* SelectSmiConstant(Node* condition, Smi* true_value, int false_value) {
+    return SelectSmiConstant(condition, true_value, Smi::FromInt(false_value));
+  }
+  Node* SelectSmiConstant(Node* condition, int true_value, int false_value) {
+    return SelectSmiConstant(condition, Smi::FromInt(true_value),
+                             Smi::FromInt(false_value));
+  }
 
   Node* TruncateWordToWord32(Node* value);
 
   // Check a value for smi-ness
   Node* TaggedIsSmi(Node* a);
   Node* TaggedIsNotSmi(Node* a);
   // Check that the value is a non-negative smi.
   Node* TaggedIsPositiveSmi(Node* a);
   // Check that a word has a word-aligned address.
   Node* WordIsWordAligned(Node* word);
@@ skipping 1006 matching lines @@
   }
 #else
 #define CSA_SLOW_ASSERT(csa, x) ((void)0)
 #endif
 
 DEFINE_OPERATORS_FOR_FLAGS(CodeStubAssembler::AllocationFlags);
 
 }  // namespace internal
 }  // namespace v8
 #endif  // V8_CODE_STUB_ASSEMBLER_H_