Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2624743002: Use generic methods in DebugIterable (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use generic methods in DebugIterable - to shut up the analyzer R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f30bb5ce437bc795b7e19e8d7c16e66eb94e3165

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M pkg/compiler/lib/src/helpers/debug_collection.dart View 2 chunks +3 lines, -4 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 11 months ago (2017-01-10 12:03:58 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2624743002/diff/1/pkg/compiler/lib/src/helpers/debug_collection.dart File pkg/compiler/lib/src/helpers/debug_collection.dart (right): https://codereview.chromium.org/2624743002/diff/1/pkg/compiler/lib/src/helpers/debug_collection.dart#newcode74 pkg/compiler/lib/src/helpers/debug_collection.dart:74: Iterable<T> map<T>( T f(E element)) => iterable.map(f); nit: ...
3 years, 11 months ago (2017-01-11 22:42:11 UTC) #3
Johnni Winther
https://codereview.chromium.org/2624743002/diff/1/pkg/compiler/lib/src/helpers/debug_collection.dart File pkg/compiler/lib/src/helpers/debug_collection.dart (right): https://codereview.chromium.org/2624743002/diff/1/pkg/compiler/lib/src/helpers/debug_collection.dart#newcode74 pkg/compiler/lib/src/helpers/debug_collection.dart:74: Iterable<T> map<T>( T f(E element)) => iterable.map(f); On 2017/01/11 ...
3 years, 11 months ago (2017-01-12 11:10:03 UTC) #4
Johnni Winther
3 years, 11 months ago (2017-01-12 11:14:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f30bb5ce437bc795b7e19e8d7c16e66eb94e3165 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698