Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2624733005: Gardening: mark regexp pcre_test slow/timeout in precompiled code (Closed)

Created:
3 years, 11 months ago by hausner
Modified:
3 years, 11 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: mark regexp pcre_test slow/timeout in precompiled code This test seems to be slow in any configuration. There are old bugs, e.g. 21593 and 22008 that mention the slowness and flakiness, but there are no takers to either fix the regexp code or make the test smaller. Note: in precompiled mode, the regular expression code is interpreted, and thus actually slower than in the JIT version of the test. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/dfde15a8bed1659df8533888d7fee7c76189656f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/corelib/corelib.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
hausner
3 years, 11 months ago (2017-01-10 20:43:44 UTC) #3
rmacnak
lgtm
3 years, 11 months ago (2017-01-10 20:59:05 UTC) #4
hausner
3 years, 11 months ago (2017-01-10 21:03:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dfde15a8bed1659df8533888d7fee7c76189656f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698