Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2624733003: Gardening: mark tests that are timing out as slow (Closed)

Created:
3 years, 11 months ago by Dmitry Olshansky
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : VM [KERNEL] Avoid emitting :expr_temp and capturing :iterator #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -3 lines) Patch
M runtime/vm/kernel_to_il.cc View 1 3 chunks +35 lines, -1 line 0 comments Download
M runtime/vm/scopes.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language_kernel.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Dmitry Olshansky
3 years, 11 months ago (2017-01-10 16:48:33 UTC) #2
kustermann
lgtm, but did you test that they actually finish if they get more time? https://codereview.chromium.org/2624733003/diff/1/tests/co19/co19-runtime.status ...
3 years, 11 months ago (2017-01-10 16:57:18 UTC) #3
Dmitry Olshansky
On 2017/01/10 16:57:18, kustermann wrote: > lgtm, but did you test that they actually finish ...
3 years, 11 months ago (2017-01-10 16:58:40 UTC) #4
Dmitry Olshansky
3 years, 11 months ago (2017-01-10 16:59:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6a6ea68f889b801745077c792c4cbad703528879 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698