Web Animations CSS: Support animation of background-position and background-image

Source/core/animation/AnimatableRepeatable.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef AnimatableSVGLength_h
-#define AnimatableSVGLength_h
+#ifndef AnimatableRepeatable_h
+#define AnimatableRepeatable_h
 
 #include "core/animation/AnimatableValue.h"
-#include "core/svg/SVGLength.h"
+#include "wtf/Vector.h"
 
 namespace WebCore {
 
-class AnimatableSVGLength: public AnimatableValue {
+class AnimatableRepeatable : public AnimatableValue {

[Steve Block, 2013/10/08 23:21:49]

'Repeatable' seems like the wrong name - it should be a noun. 'RepeatedValue'?
'Vector'? 'List'?

[alancutter (OOO until 2018), 2013/10/09 07:20:55]

Repeatable refers to the way this value interpolates and matches the language
used in the transitions spec:
http://www.w3.org/TR/css3-transitions/#animtype-repeatable-list
Added comment to class explaining this.

 public:
-    virtual ~AnimatableSVGLength() { }
+    virtual ~AnimatableRepeatable() { }
 
-    static PassRefPtr<AnimatableSVGLength> create(const SVGLength& length)
+    // This will consume the vector passed into it.
+    static PassRefPtr<AnimatableRepeatable> create(Vector<RefPtr<AnimatableValue> >& values)
     {
-        return adoptRef(new AnimatableSVGLength(length));
+        return adoptRef(new AnimatableRepeatable(values));
     }
 
-    const SVGLength& toSVGLength() const
+    const Vector<RefPtr<AnimatableValue> >& values() const { return m_values; }
+
+private:
+    AnimatableRepeatable(Vector<RefPtr<AnimatableValue> >& values)
     {
-        return m_length;
+        ASSERT(!values.isEmpty());

[dstockwell, 2013/10/08 22:57:31]

why?

[alancutter (OOO until 2018), 2013/10/09 07:20:55]

Removed non-zero length constraint.

+        m_values.swap(values);
     }
 
-protected:
     virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE;
     virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OVERRIDE;
 
-private:
-    AnimatableSVGLength(const SVGLength& length)
-        : m_length(length)
-    {
-    }
-
-    virtual AnimatableType type() const { return TypeSVGLength; }
+    virtual AnimatableType type() const OVERRIDE { return TypeRepeatable; }
     virtual bool equalTo(const AnimatableValue*) const OVERRIDE;
 
-    SVGLength m_length;
+    Vector<RefPtr<AnimatableValue> > m_values;
 };
 
-inline const AnimatableSVGLength* toAnimatableSVGLength(const AnimatableValue* value)
+inline const AnimatableRepeatable* toAnimatableRepeatable(const AnimatableValue* value)
 {
-    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isSVGLength());
-    return static_cast<const AnimatableSVGLength*>(value);
+    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isRepeatable());
+    return static_cast<const AnimatableRepeatable*>(value);
 }
 
 } // namespace WebCore
 
-#endif // AnimatableSVGLength_h
+#endif // AnimatableRepeatable_h