Remove Sync GetPose VRService call, implement VRVSyncProvider

third_party/WebKit/Source/modules/vr/VRDisplay.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VRDisplay_h
 #define VRDisplay_h
 
 #include "core/dom/Document.h"
 #include "core/dom/FrameRequestCallback.h"
+#include "core/dom/TaskRunnerHelper.h"

[haraken, 2017/01/19 00:49:56]

Not needed?

[mthiesse, 2017/01/19 00:54:04]

Done.

 #include "core/events/EventTarget.h"
 #include "device/vr/vr_service.mojom-blink.h"
 #include "modules/vr/VRDisplayCapabilities.h"
 #include "modules/vr/VRLayer.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "platform/Timer.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/WebGraphicsContext3DProvider.h"
 #include "wtf/Forward.h"
 #include "wtf/text/WTFString.h"
@@ skipping 45 matching lines @@
   double depthNear() const { return m_depthNear; }
   double depthFar() const { return m_depthFar; }
 
   void setDepthNear(double value) { m_depthNear = value; }
   void setDepthFar(double value) { m_depthFar = value; }
 
   VREyeParameters* getEyeParameters(const String&);
 
   int requestAnimationFrame(FrameRequestCallback*);
   void cancelAnimationFrame(int id);
-  void serviceScriptedAnimations(double monotonicAnimationStartTime);
 
   ScriptPromise requestPresent(ScriptState*, const HeapVector<VRLayer>& layers);
   ScriptPromise exitPresent(ScriptState*);
 
   HeapVector<VRLayer> getLayers();
 
   void submitFrame();
 
   Document* document();
 
@@ skipping 38 matching lines @@
   void OnPresentChange();
 
   // VRDisplayClient
   void OnChanged(device::mojom::blink::VRDisplayInfoPtr) override;
   void OnExitPresent() override;
   void OnBlur() override;
   void OnFocus() override;
   void OnActivate(device::mojom::blink::VRDisplayEventReason) override;
   void OnDeactivate(device::mojom::blink::VRDisplayEventReason) override;
 
+  void OnVSync(device::mojom::blink::VRPosePtr,
+               mojo::common::mojom::blink::TimeDeltaPtr);
+  void ConnectVSyncProvider();
+
   ScriptedAnimationController& ensureScriptedAnimationController(Document*);
 
   Member<NavigatorVR> m_navigatorVR;
-  unsigned m_displayId;
+  unsigned m_displayId = 0;
   String m_displayName;
-  bool m_isConnected;
-  bool m_isPresenting;
-  bool m_isValidDeviceForPresenting;
-  bool m_canUpdateFramePose;
+  bool m_isConnected = false;
+  bool m_isPresenting = false;
+  bool m_isValidDeviceForPresenting = true;
   Member<VRDisplayCapabilities> m_capabilities;
   Member<VRStageParameters> m_stageParameters;
   Member<VREyeParameters> m_eyeParametersLeft;
   Member<VREyeParameters> m_eyeParametersRight;
   device::mojom::blink::VRPosePtr m_framePose;
   VRLayer m_layer;
-  double m_depthNear;
-  double m_depthFar;
+  double m_depthNear = 0.01;
+  double m_depthFar = 10000.0;
 
   void dispose();
 
   Timer<VRDisplay> m_fullscreenCheckTimer;
   String m_fullscreenOrigWidth;
   String m_fullscreenOrigHeight;
-  gpu::gles2::GLES2Interface* m_contextGL;
+  gpu::gles2::GLES2Interface* m_contextGL = nullptr;
   Member<WebGLRenderingContextBase> m_renderingContext;
 
   Member<ScriptedAnimationController> m_scriptedAnimationController;
-  bool m_animationCallbackRequested;
-  bool m_inAnimationFrame;
-  bool m_displayBlurred;
-  bool m_reenteredFullscreen;
+  bool m_pendingRaf = false;
+  bool m_inAnimationFrame = false;
+  bool m_displayBlurred = false;
+  bool m_reenteredFullscreen = false;
+  double m_timebase = -1;
 
   device::mojom::blink::VRDisplayPtr m_display;
 
-  mojo::Binding<device::mojom::blink::VRDisplayClient> m_binding;
+  mojo::Binding<device::mojom::blink::VRDisplayClient> m_displayClientBinding;
+  device::mojom::blink::VRVSyncProviderPtr m_vrVSyncProvider;
 
   HeapDeque<Member<ScriptPromiseResolver>> m_pendingPresentResolvers;
 };
 
 using VRDisplayVector = HeapVector<Member<VRDisplay>>;
 
 enum class PresentationResult {
   Requested = 0,
   Success = 1,
   SuccessAlreadyPresenting = 2,
   VRDisplayCannotPresent = 3,
   PresentationNotSupportedByDisplay = 4,
   VRDisplayNotFound = 5,
   NotInitiatedByUserGesture = 6,
   InvalidNumberOfLayers = 7,
   InvalidLayerSource = 8,
   LayerSourceMissingWebGLContext = 9,
   InvalidLayerBounds = 10,
   ServiceInactive = 11,
   RequestDenied = 12,
   PresentationResultMax,  // Must be last member of enum.
 };
 
 void ReportPresentationResult(PresentationResult);
 
 }  // namespace blink
 
 #endif  // VRDisplay_h