Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: content/browser/browser_child_process_host_impl.h

Issue 2624613003: content: Change how a bad message from a child is logged. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_child_process_host_impl.h
diff --git a/content/browser/browser_child_process_host_impl.h b/content/browser/browser_child_process_host_impl.h
index 9975dc1aa692912a76b37f63de7692c66e96091e..6eeb94220df43a87122c845bd062f666dd09772d 100644
--- a/content/browser/browser_child_process_host_impl.h
+++ b/content/browser/browser_child_process_host_impl.h
@@ -92,9 +92,9 @@ class CONTENT_EXPORT BrowserChildProcessHostImpl
void OnChannelError() override;
void OnBadMessageReceived(const IPC::Message& message) override;
- // Terminates the process and logs an error after a bad message was received
- // from the child process.
- void TerminateOnBadMessageReceived(uint32_t type);
+ // Terminates the process and logs an stack trace after a bad message was
Charlie Reis 2017/01/10 23:06:43 nit: s/an/a/
sadrul 2017/01/11 02:29:13 Done.
+ // received from the child process.
+ void TerminateOnBadMessageReceived(const std::string& error);
// Removes this host from the host list. Calls ChildProcessHost::ForceShutdown
void ForceShutdown();
« no previous file with comments | « no previous file | content/browser/browser_child_process_host_impl.cc » ('j') | content/browser/browser_child_process_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698