Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: chrome/browser/component_updater/recovery_component_installer.cc

Issue 2624583002: Remove redundant c_str() calls. (Closed)
Patch Set: Revert some changes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/component_updater/pnacl_component_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/recovery_component_installer.cc
diff --git a/chrome/browser/component_updater/recovery_component_installer.cc b/chrome/browser/component_updater/recovery_component_installer.cc
index 8ced201a19639919e1791190358752b288b1b88e..7b72e3de143aa249b2e6f8533c84efd55e15743e 100644
--- a/chrome/browser/component_updater/recovery_component_installer.cc
+++ b/chrome/browser/component_updater/recovery_component_installer.cc
@@ -173,7 +173,7 @@ void DoElevatedInstallRecoveryComponent(const base::FilePath& path) {
return;
std::string proposed_version;
manifest->GetStringASCII("version", &proposed_version);
- const base::Version version(proposed_version.c_str());
+ const base::Version version(proposed_version);
if (!version.IsValid())
return;
@@ -418,7 +418,7 @@ bool RecoveryComponentInstaller::DoInstall(
return false;
std::string proposed_version;
manifest.GetStringASCII("version", &proposed_version);
- base::Version version(proposed_version.c_str());
+ base::Version version(proposed_version);
if (!version.IsValid())
return false;
if (current_version_.CompareTo(version) >= 0)
« no previous file with comments | « chrome/browser/component_updater/pnacl_component_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698