Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2452)

Unified Diff: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc

Issue 2624583002: Remove redundant c_str() calls. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/trace_event/trace_config.cc ('K') | « chrome/browser/font_family_cache.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
diff --git a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
index 69cfd8981ffdf9c04b3283b4fcd79c42b51c0751..93dd615e7faa3493fccf22012c3c9e3d984156a8 100644
--- a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
+++ b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
@@ -774,7 +774,7 @@ void ChromeResourceDispatcherHostDelegate::OnResponseStarted(
#if BUILDFLAG(ENABLE_EXTENSIONS)
GURL webstore_url(extension_urls::GetWebstoreLaunchURL());
if (request->url().SchemeIsHTTPOrHTTPS() &&
- request->url().DomainIs(webstore_url.host().c_str())) {
+ request->url().DomainIs(webstore_url.host())) {
Charlie Harrison 2017/01/10 00:20:35 Drive-by: this does a string copy. You should use
Andrey Kraynov 2017/01/10 11:15:18 Thanks for pointing! Done.
net::HttpResponseHeaders* response_headers = request->response_headers();
if (response_headers &&
!response_headers->HasHeaderValue("x-frame-options", "deny") &&
« base/trace_event/trace_config.cc ('K') | « chrome/browser/font_family_cache.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698