chrome/browser/component_updater/swiftshader_component_installer.cc - Issue 2624583002: Remove redundant c_str() calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/swiftshader_component_installer.cc

Issue 2624583002: Remove redundant c_str() calls. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/trace_event/trace_config.cc ('K') | « chrome/browser/component_updater/recovery_component_installer.cc ('k') | chrome/browser/devtools/device/port_forwarding_controller.cc » ('j') | chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/swiftshader_component_installer.cc

diff --git a/chrome/browser/component_updater/swiftshader_component_installer.cc b/chrome/browser/component_updater/swiftshader_component_installer.cc

index 05cdadde2928ab7c110518afcfc10dd3cb49d841..957a73ef5f21a29c8992fa24458a769221603f83 100644

--- a/chrome/browser/component_updater/swiftshader_component_installer.cc

+++ b/chrome/browser/component_updater/swiftshader_component_installer.cc

@@ -151,7 +151,7 @@ bool SwiftShaderComponentInstaller::DoInstall(

return false;

std::string proposed_version;

manifest.GetStringASCII("version", &proposed_version);

- base::Version version(proposed_version.c_str());

+ base::Version version(proposed_version);

if (!version.IsValid())

return false;

if (current_version_.CompareTo(version) >= 0)