Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2624573002: MD Settings: Internet: UI For global policy (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
fqj, emaxx
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-closure_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: UI For global policy This includes UI for the following policies: AllowOnlyPolicyNetworksToConnect AllowOnlyPolicyNetworksToAutoconnect BUG=678786 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Rebase + Wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -45 lines) Patch
M chrome/app/settings_strings.grdp View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 2 6 chunks +15 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 5 chunks +45 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 2 1 chunk +37 lines, -25 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.js View 3 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_shared_css.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.js View 1 2 4 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_network_behavior.js View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
See https://codereview.chromium.org/2620463003/ for the networkingPrivate API change to support this.
3 years, 11 months ago (2017-01-09 21:11:36 UTC) #3
stevenjb
+emaxx@
3 years, 11 months ago (2017-01-09 21:12:35 UTC) #5
emaxx
lgtm https://codereview.chromium.org/2624573002/diff/2/chrome/browser/resources/settings/internet_page/internet_page.html File chrome/browser/resources/settings/internet_page/internet_page.html (right): https://codereview.chromium.org/2624573002/diff/2/chrome/browser/resources/settings/internet_page/internet_page.html#newcode55 chrome/browser/resources/settings/internet_page/internet_page.html:55: <button class="icon-external" is="paper-icon-button-light"></button> nit: This line and line ...
3 years, 11 months ago (2017-01-17 22:14:06 UTC) #6
stevenjb
https://codereview.chromium.org/2624573002/diff/2/chrome/browser/resources/settings/internet_page/internet_page.html File chrome/browser/resources/settings/internet_page/internet_page.html (right): https://codereview.chromium.org/2624573002/diff/2/chrome/browser/resources/settings/internet_page/internet_page.html#newcode55 chrome/browser/resources/settings/internet_page/internet_page.html:55: <button class="icon-external" is="paper-icon-button-light"></button> On 2017/01/17 22:14:06, emaxx wrote: > ...
3 years, 11 months ago (2017-01-17 22:27:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2624573002/30001
3 years, 11 months ago (2017-01-17 22:28:24 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 23:36:32 UTC) #13
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698