Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2624563003: Switch AnalysisDriver tests to using the physical SDK. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch AnalysisDriver tests to using the physical SDK. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/619033a6331ef25b823dcc39bbf9c22d451b86aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M pkg/analyzer/test/src/dart/analysis/base.dart View 3 chunks +1 line, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +1 line, -3 lines 0 comments Download
A pkg/analyzer/test/src/dart/analysis/physical_sdk.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-09 20:57:29 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-09 20:58:59 UTC) #2
scheglov
3 years, 11 months ago (2017-01-09 21:03:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
619033a6331ef25b823dcc39bbf9c22d451b86aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698