Issue 262453002: reland r14391 ('fix contents of render_pictures JSON summary')

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 262453002: reland r14391 ('fix contents of render_pictures JSON summary') (Closed)

Created:
6 years, 7 months ago by epoger

Modified:
6 years, 7 months ago

Reviewers:
caryclark

CC:
skia-review_googlegroups.com, benchen

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

reland r14391 ('fix contents of render_pictures JSON summary') BUG=skia:2043, skia:2044, skia:1942, skia:2466 TBR=caryclark Committed: http://code.google.com/p/skia/source/detail?r=14443

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -164 lines)			Patch
M	tools/PictureRenderer.cpp	View	6 chunks	+17 lines, -35 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	tools/tests/render_pictures_test.py	View	6 chunks	+134 lines, -123 lines	0 comments	Download

Total messages: 5 (0 generated)

epoger

Discussed live with Cary... I'm going to land this change, knowing that it will break ...

6 years, 7 months ago (2014-04-29 19:09:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/262453002/1

6 years, 7 months ago (2014-04-29 19:09:46 UTC) #3

epoger

On 2014/04/29 19:09:10, epoger wrote: > Once those CheckForRegressions failures come in, I will rebaseline ...

6 years, 7 months ago (2014-04-29 19:37:26 UTC) #4

Message was sent while issue was closed.

Change committed as 14443