Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Side by Side Diff: chrome/browser/resources/settings/people_page/people_page.js

Issue 2624503002: Add web_dev_style presubmit to ensure <if>/<include> live in comments (Closed)
Patch Set: '<iframe' Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/js_checker.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-people-page' is the settings page containing sign-in settings. 7 * 'settings-people-page' is the settings page containing sign-in settings.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-people-page', 10 is: 'settings-people-page',
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 240
241 /** 241 /**
242 * Handler for when the sync state is pushed from the browser. 242 * Handler for when the sync state is pushed from the browser.
243 * @param {?settings.SyncStatus} syncStatus 243 * @param {?settings.SyncStatus} syncStatus
244 * @private 244 * @private
245 */ 245 */
246 handleSyncStatus_: function(syncStatus) { 246 handleSyncStatus_: function(syncStatus) {
247 if (!this.syncStatus && syncStatus && !syncStatus.signedIn) 247 if (!this.syncStatus && syncStatus && !syncStatus.signedIn)
248 chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings'); 248 chrome.metricsPrivate.recordUserAction('Signin_Impression_FromSettings');
249 249
250 <if expr="not chromeos"> 250 // <if expr="not chromeos">
251 if (syncStatus.signedIn) 251 if (syncStatus.signedIn)
252 settings.ProfileInfoBrowserProxyImpl.getInstance().getProfileStatsCount(); 252 settings.ProfileInfoBrowserProxyImpl.getInstance().getProfileStatsCount();
253 </if> 253 // </if>
254 254
255 if (!syncStatus.signedIn && this.$.disconnectDialog.open) 255 if (!syncStatus.signedIn && this.$.disconnectDialog.open)
256 this.$.disconnectDialog.close(); 256 this.$.disconnectDialog.close();
257 257
258 this.syncStatus = syncStatus; 258 this.syncStatus = syncStatus;
259 }, 259 },
260 260
261 // <if expr="chromeos"> 261 // <if expr="chromeos">
262 /** 262 /**
263 * Handler for when the Easy Unlock enabled status has changed. 263 * Handler for when the Easy Unlock enabled status has changed.
(...skipping 246 matching lines...) Expand 10 before | Expand all | Expand 10 after
510 510
511 /** 511 /**
512 * @param {!settings.SyncStatus} syncStatus 512 * @param {!settings.SyncStatus} syncStatus
513 * @return {boolean} Whether to show the "Sign in to Chrome" button. 513 * @return {boolean} Whether to show the "Sign in to Chrome" button.
514 * @private 514 * @private
515 */ 515 */
516 showSignin_: function(syncStatus) { 516 showSignin_: function(syncStatus) {
517 return !!syncStatus.signinAllowed && !syncStatus.signedIn; 517 return !!syncStatus.signinAllowed && !syncStatus.signedIn;
518 }, 518 },
519 }); 519 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/web_dev_style/js_checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698