third_party/WebKit/Source/wtf/text/StringImplTest.cpp - Issue 2624443003: Enable ThreadRestrictionVerifier for StringImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImplTest.cpp

Issue 2624443003: Enable ThreadRestrictionVerifier for StringImpl (Closed)

Patch Set: minimal const peppering Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImplTest.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringImplTest.cpp b/third_party/WebKit/Source/wtf/text/StringImplTest.cpp

index 7dab3d9457f54d163f41e187dd636b26d7fe7004..9843a07eb4df4df003404130bdc5736bf335ead4 100644

--- a/third_party/WebKit/Source/wtf/text/StringImplTest.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringImplTest.cpp

@@ -89,6 +89,9 @@ TEST(StringImplTest, LowerASCII) {

static const UChar testWithNonASCIICapitalized[3] = {0x0041, 0x00e1,

0}; // A\xE1

+ // Make sure we support RefPtr<const StringImpl>.

+ RefPtr<const StringImpl> constRef = testStringImpl->isolatedCopy();

+ DCHECK(constRef->hasOneRef());

EXPECT_TRUE(equal(

StringImpl::create(testWithNonASCII, 2).get(),

StringImpl::create(testWithNonASCIICapitalized, 2)->lowerASCII().get()));