Enable ThreadRestrictionVerifier for StringImpl

third_party/WebKit/Source/wtf/text/StringImpl.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 17 matching lines @@
 #include "wtf/Forward.h"
 #include "wtf/HashMap.h"
 #include "wtf/StringHasher.h"
 #include "wtf/Vector.h"
 #include "wtf/WTFExport.h"
 #include "wtf/text/ASCIIFastPath.h"
 #include "wtf/text/Unicode.h"
 #include <limits.h>
 #include <string.h>
 
+#if DCHECK_IS_ON()
+#include "wtf/ThreadRestrictionVerifier.h"
+#endif
+
 #if OS(MACOSX)
 typedef const struct __CFString* CFStringRef;
 #endif
 
 #ifdef __OBJC__
 @class NSString;
 #endif
 
 namespace WTF {
 
@@ skipping 242 matching lines @@
     DCHECK(hasHash());
     return m_hash;
   }
 
   unsigned hash() const {
     if (hasHash())
       return existingHash();
     return hashSlowCase();
   }
 
-  ALWAYS_INLINE bool hasOneRef() const { return m_refCount == 1; }
+  ALWAYS_INLINE bool hasOneRef() const {
+#if DCHECK_IS_ON()
+    DCHECK(isStatic() || m_verifier.isSafeToUse()) << asciiForDebugging();
+#endif
+    return m_refCount == 1;
+  }
 
-  ALWAYS_INLINE void ref() { ++m_refCount; }
+  ALWAYS_INLINE void ref() const {
+#if DCHECK_IS_ON()
+    DCHECK(isStatic() || m_verifier.onRef(m_refCount)) << asciiForDebugging();
+#endif
+    ++m_refCount;
+  }
 
-  ALWAYS_INLINE void deref() {
+  ALWAYS_INLINE void deref() const {
+#if DCHECK_IS_ON()
+    DCHECK(isStatic() || m_verifier.onDeref(m_refCount))
+        << asciiForDebugging() << " " << currentThread();
+#endif
     if (!--m_refCount)
       destroyIfNotStatic();
   }
 
   static StringImpl* empty();
   static StringImpl* empty16Bit();
 
   // FIXME: Does this really belong in StringImpl?
   template <typename T>
   static void copyChars(T* destination,
                         const T* source,
                         unsigned numCharacters) {
     memcpy(destination, source, numCharacters * sizeof(T));
   }
 
   ALWAYS_INLINE static void copyChars(UChar* destination,
                                       const LChar* source,
                                       unsigned numCharacters) {
     for (unsigned i = 0; i < numCharacters; ++i)
       destination[i] = source[i];
   }
 
   // Some string features, like refcounting and the atomicity flag, are not
   // thread-safe. We achieve thread safety by isolation, giving each thread
   // its own copy of the string.
   PassRefPtr<StringImpl> isolatedCopy() const;
 
-  PassRefPtr<StringImpl> substring(unsigned pos, unsigned len = UINT_MAX);
+  PassRefPtr<StringImpl> substring(unsigned pos, unsigned len = UINT_MAX) const;
 
   UChar operator[](unsigned i) const {
     SECURITY_DCHECK(i < m_length);
     if (is8Bit())
       return characters8()[i];
     return characters16()[i];
   }
   UChar32 characterStartingAt(unsigned);
 
   bool containsOnlyWhitespace();
@@ skipping 137 matching lines @@
                                  const UChar* replacement,
                                  unsigned replacementLength);
 
   template <class UCharPredicate>
   PassRefPtr<StringImpl> stripMatchedCharacters(UCharPredicate);
   template <typename CharType, class UCharPredicate>
   PassRefPtr<StringImpl> simplifyMatchedCharactersToSpace(UCharPredicate,
                                                           StripBehavior);
   NEVER_INLINE unsigned hashSlowCase() const;
 
-  void destroyIfNotStatic();
+  void destroyIfNotStatic() const;
   void updateContainsOnlyASCII() const;
 
+#if DCHECK_IS_ON()
+  std::string asciiForDebugging() const;
+#endif
+
 #ifdef STRING_STATS
   static StringStats m_stringStats;
 #endif
 
   static unsigned m_highestStaticStringLength;
 
 #if DCHECK_IS_ON()
   void assertHashIsCorrect() {
     DCHECK(hasHash());
     DCHECK_EQ(existingHash(), StringHasher::computeHashAndMaskTop8Bits(
                                   characters8(), length()));
   }
 #endif
 
  private:
-  unsigned m_refCount;
+#if DCHECK_IS_ON()
+  mutable ThreadRestrictionVerifier m_verifier;
+#endif
+  mutable unsigned m_refCount;
   const unsigned m_length;
   mutable unsigned m_hash : 24;
   mutable unsigned m_containsOnlyASCII : 1;
   mutable unsigned m_needsASCIICheck : 1;
   unsigned m_isAtomic : 1;
   const unsigned m_is8Bit : 1;
   const unsigned m_isStatic : 1;
 };
 
 template <>
@@ skipping 341 matching lines @@
 using WTF::TextCaseASCIIInsensitive;
 using WTF::TextCaseUnicodeInsensitive;
 using WTF::TextCaseSensitive;
 using WTF::TextCaseSensitivity;
 using WTF::equal;
 using WTF::equalNonNull;
 using WTF::lengthOfNullTerminatedString;
 using WTF::reverseFind;
 
 #endif