Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 2624443002: [Android WebView] Remove postOnPageFinished from shouldInterceptRequest. (Closed)
Patch Set: Fix Selim's nits (comment fixes). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index f868572acdf78ff9beea53b8581a82c4d16136e4..59b664e24d2a301768417a7be97f4ca9a2c82a20 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -495,14 +495,12 @@ public class AwContents implements SmartClipProvider, PostMessageSender.PostMess
if (awWebResourceResponse != null && awWebResourceResponse.getData() == null) {
// In this case the intercepted URLRequest job will simulate an empty response
- // which doesn't trigger the onReceivedError or onPageFinished callbacks. For
- // WebViewClassic compatibility we synthesize those callbacks.
- // http://crbug.com/180950
+ // which doesn't trigger the onReceivedError callback. For WebViewClassic
+ // compatibility we synthesize that callback. http://crbug.com/180950
mContentsClient.getCallbackHelper().postOnReceivedError(
request,
/* error description filled in by the glue layer */
new AwContentsClient.AwWebResourceError());
- mContentsClient.getCallbackHelper().postOnPageFinished(request.url);
}
return awWebResourceResponse;
}
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698