Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: content/browser/speech/speech_recognizer_impl.cc

Issue 2624403002: Refactor AudioInputController and related interfaces. (Closed)
Patch Set: Address comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/speech/speech_recognizer_impl.cc
diff --git a/content/browser/speech/speech_recognizer_impl.cc b/content/browser/speech/speech_recognizer_impl.cc
index 0bc6261453c0c0cdac9c77acc09db4a9bee85011..d79c17113f2bcb22f5afd3969fd82a66854630bb 100644
--- a/content/browser/speech/speech_recognizer_impl.cc
+++ b/content/browser/speech/speech_recognizer_impl.cc
@@ -276,8 +276,10 @@ void SpeechRecognizerImpl::OnError(AudioInputController* controller,
this, event_args));
}
-void SpeechRecognizerImpl::OnData(AudioInputController* controller,
- const AudioBus* data) {
+void SpeechRecognizerImpl::Write(const AudioBus* data,
+ double volume,
+ bool key_pressed,
+ uint32_t hardware_delay_bytes) {
// Convert audio from native format to fixed format used by WebSpeech.
FSMEventArgs event_args(EVENT_AUDIO_DATA);
event_args.audio_data = audio_converter_->Convert(data);
@@ -297,6 +299,8 @@ void SpeechRecognizerImpl::OnData(AudioInputController* controller,
CHECK(audio_converter_->data_was_converted());
}
+void SpeechRecognizerImpl::Close() {}
+
void SpeechRecognizerImpl::OnAudioClosed(AudioInputController*) {}
void SpeechRecognizerImpl::OnSpeechRecognitionEngineResults(
@@ -585,7 +589,7 @@ SpeechRecognizerImpl::StartRecording(const FSMEventArgs&) {
new OnDataConverter(input_parameters, output_parameters));
audio_controller_ = AudioInputController::Create(
- audio_manager, this, input_parameters, device_id_, NULL);
+ audio_manager, this, this, input_parameters, device_id_, NULL);
if (!audio_controller_.get()) {
return Abort(
« no previous file with comments | « content/browser/speech/speech_recognizer_impl.h ('k') | content/browser/speech/speech_recognizer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698