Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2624393002: Remove dart_noopt and related parts from the VM. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
rmacnak, kustermann
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dart_noopt and related parts from the VM. dart_noopt is not needed anymore because we have testing and builbot integration of the real precompilation pipeline in place now. Fixes #24569 Fixes #25726 Fixes #25845 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bef4967ea1b5399cc7d74273db44e0570507b801

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of github.com:dart-lang/sdk into remove-noopt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -280 lines) Patch
M BUILD.gn View 3 chunks +5 lines, -19 lines 0 comments Download
M dart.gyp View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/bin/bin.gypi View 1 chunk +0 lines, -57 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 8 chunks +9 lines, -41 lines 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/dart-runtime.gyp View 1 chunk +0 lines, -35 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/lib/vmservice.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/precompiler.h View 3 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/precompiler.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 2 chunks +4 lines, -4 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +4 lines, -5 lines 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 5 chunks +7 lines, -21 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
I tried to identify all affected places, but let me know if I missed something ...
3 years, 11 months ago (2017-01-12 00:27:44 UTC) #2
rmacnak
LGTM
3 years, 11 months ago (2017-01-12 00:41:41 UTC) #3
Florian Schneider
3 years, 11 months ago (2017-01-12 00:56:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
bef4967ea1b5399cc7d74273db44e0570507b801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698