Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ui/login/account_picker/user_pod_row.js

Issue 2624383004: cros: Lock Screen: Fixed an issue with tab order on the lock screen. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/login/account_picker/user_pod_row.js
diff --git a/ui/login/account_picker/user_pod_row.js b/ui/login/account_picker/user_pod_row.js
index 50bfff4e495da75e891ae1dd007b9839ebfde4ff..e54482990351299f6daf51c3b2104f742b4ba3b2 100644
--- a/ui/login/account_picker/user_pod_row.js
+++ b/ui/login/account_picker/user_pod_row.js
@@ -89,11 +89,13 @@ cr.define('login', function() {
* @const
*/
var UserPodTabOrder = {
- POD_INPUT: 1, // Password input field, Action box menu button, and
- // the pod itself.
- POD_CUSTOM_ICON: 2, // Pod custom icon next to password input field.
- HEADER_BAR: 3, // Buttons on the header bar (Shutdown, Add User).
- POD_MENU_ITEM: 4 // User pad menu items (User info, Remove user).
+ POD_INPUT: 1, // Password input field, Action box menu button, submit
+ // button newxt to password input field and the pod
jdufault 2017/01/12 20:43:03 newxt => next
sammiequon 2017/01/17 20:00:56 Done.
+ // itself.
+ PIN_KEYBOARD: 2, // Pin keyboard below the password input field.
+ POD_CUSTOM_ICON: 3, // Pod custom icon next to password input field.
+ HEADER_BAR: 4, // Buttons on the header bar (Shutdown, Add User).
+ POD_MENU_ITEM: 5 // User pad menu items (User info, Remove user).
};
/**
@@ -722,6 +724,7 @@ cr.define('login', function() {
this.pinKeyboard.passwordElement = this.passwordElement;
this.pinKeyboard.addEventListener('pin-change',
this.handleInputChanged_.bind(this));
+ this.pinKeyboard.tabIndex = UserPodTabOrder.PIN_KEYBOARD;
}
this.actionBoxAreaElement.addEventListener('mousedown',
@@ -767,6 +770,7 @@ cr.define('login', function() {
if (this.submitButton) {
this.submitButton.addEventListener('click',
this.handleSubmitButtonClick_.bind(this));
+ this.submitButton.tabIndex = UserPodTabOrder.POD_INPUT;
}
this.imageElement.addEventListener('load',

Powered by Google App Engine
This is Rietveld 408576698