Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: ui/login/account_picker/user_pod_row.js

Issue 2624383004: cros: Lock Screen: Fixed an issue with tab order on the lock screen. (Closed)
Patch Set: Nit. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview User pod row implementation. 6 * @fileoverview User pod row implementation.
7 */ 7 */
8 8
9 cr.define('login', function() { 9 cr.define('login', function() {
10 /** 10 /**
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 * @const 82 * @const
83 */ 83 */
84 var HELP_TOPIC_PUBLIC_SESSION = 3041033; 84 var HELP_TOPIC_PUBLIC_SESSION = 3041033;
85 85
86 /** 86 /**
87 * Tab order for user pods. Update these when adding new controls. 87 * Tab order for user pods. Update these when adding new controls.
88 * @enum {number} 88 * @enum {number}
89 * @const 89 * @const
90 */ 90 */
91 var UserPodTabOrder = { 91 var UserPodTabOrder = {
92 POD_INPUT: 1, // Password input field, Action box menu button, and 92 POD_INPUT: 1, // Password input field, Action box menu button, submit
93 // the pod itself. 93 // button next to password input field and the pod
94 POD_CUSTOM_ICON: 2, // Pod custom icon next to password input field. 94 // itself.
95 HEADER_BAR: 3, // Buttons on the header bar (Shutdown, Add User). 95 PIN_KEYBOARD: 2, // Pin keyboard below the password input field.
96 POD_MENU_ITEM: 4 // User pad menu items (User info, Remove user). 96 POD_CUSTOM_ICON: 3, // Pod custom icon next to password input field.
97 HEADER_BAR: 4, // Buttons on the header bar (Shutdown, Add User).
98 POD_MENU_ITEM: 5 // User pad menu items (User info, Remove user).
97 }; 99 };
98 100
99 /** 101 /**
100 * Supported authentication types. Keep in sync with the enum in 102 * Supported authentication types. Keep in sync with the enum in
101 * chrome/browser/signin/screenlock_bridge.h 103 * chrome/browser/signin/screenlock_bridge.h
102 * @enum {number} 104 * @enum {number}
103 * @const 105 * @const
104 */ 106 */
105 var AUTH_TYPE = { 107 var AUTH_TYPE = {
106 OFFLINE_PASSWORD: 0, 108 OFFLINE_PASSWORD: 0,
(...skipping 608 matching lines...) Expand 10 before | Expand all | Expand 10 after
715 this.actionBoxAreaElement.tabIndex = UserPodTabOrder.POD_INPUT; 717 this.actionBoxAreaElement.tabIndex = UserPodTabOrder.POD_INPUT;
716 718
717 this.addEventListener('keydown', this.handlePodKeyDown_.bind(this)); 719 this.addEventListener('keydown', this.handlePodKeyDown_.bind(this));
718 this.addEventListener('click', this.handleClickOnPod_.bind(this)); 720 this.addEventListener('click', this.handleClickOnPod_.bind(this));
719 this.addEventListener('mousedown', this.handlePodMouseDown_.bind(this)); 721 this.addEventListener('mousedown', this.handlePodMouseDown_.bind(this));
720 722
721 if (this.pinKeyboard) { 723 if (this.pinKeyboard) {
722 this.pinKeyboard.passwordElement = this.passwordElement; 724 this.pinKeyboard.passwordElement = this.passwordElement;
723 this.pinKeyboard.addEventListener('pin-change', 725 this.pinKeyboard.addEventListener('pin-change',
724 this.handleInputChanged_.bind(this)); 726 this.handleInputChanged_.bind(this));
727 this.pinKeyboard.tabIndex = UserPodTabOrder.PIN_KEYBOARD;
725 } 728 }
726 729
727 this.actionBoxAreaElement.addEventListener('mousedown', 730 this.actionBoxAreaElement.addEventListener('mousedown',
728 stopEventPropagation); 731 stopEventPropagation);
729 this.actionBoxAreaElement.addEventListener('click', 732 this.actionBoxAreaElement.addEventListener('click',
730 this.handleActionAreaButtonClick_.bind(this)); 733 this.handleActionAreaButtonClick_.bind(this));
731 this.actionBoxAreaElement.addEventListener('keydown', 734 this.actionBoxAreaElement.addEventListener('keydown',
732 this.handleActionAreaButtonKeyDown_.bind(this)); 735 this.handleActionAreaButtonKeyDown_.bind(this));
733 736
734 this.actionBoxMenuTitleElement.addEventListener('keydown', 737 this.actionBoxMenuTitleElement.addEventListener('keydown',
(...skipping 25 matching lines...) Expand all
760 this.passwordElement.addEventListener('keypress', 763 this.passwordElement.addEventListener('keypress',
761 this.handlePasswordKeyPress_.bind(this)); 764 this.handlePasswordKeyPress_.bind(this));
762 this.passwordElement.addEventListener('input', 765 this.passwordElement.addEventListener('input',
763 this.handleInputChanged_.bind(this)); 766 this.handleInputChanged_.bind(this));
764 this.passwordElement.addEventListener('mouseup', 767 this.passwordElement.addEventListener('mouseup',
765 this.handleInputMouseUp_.bind(this)); 768 this.handleInputMouseUp_.bind(this));
766 769
767 if (this.submitButton) { 770 if (this.submitButton) {
768 this.submitButton.addEventListener('click', 771 this.submitButton.addEventListener('click',
769 this.handleSubmitButtonClick_.bind(this)); 772 this.handleSubmitButtonClick_.bind(this));
773 this.submitButton.tabIndex = UserPodTabOrder.POD_INPUT;
770 } 774 }
771 775
772 this.imageElement.addEventListener('load', 776 this.imageElement.addEventListener('load',
773 this.parentNode.handlePodImageLoad.bind(this.parentNode, this)); 777 this.parentNode.handlePodImageLoad.bind(this.parentNode, this));
774 778
775 var initialAuthType = this.user.initialAuthType || 779 var initialAuthType = this.user.initialAuthType ||
776 AUTH_TYPE.OFFLINE_PASSWORD; 780 AUTH_TYPE.OFFLINE_PASSWORD;
777 this.setAuthType(initialAuthType, null); 781 this.setAuthType(initialAuthType, null);
778 782
779 this.userClickAuthAllowed_ = false; 783 this.userClickAuthAllowed_ = false;
(...skipping 2941 matching lines...) Expand 10 before | Expand all | Expand 10 after
3721 if (pod && pod.multiProfilesPolicyApplied) { 3725 if (pod && pod.multiProfilesPolicyApplied) {
3722 pod.userTypeBubbleElement.classList.remove('bubble-shown'); 3726 pod.userTypeBubbleElement.classList.remove('bubble-shown');
3723 } 3727 }
3724 } 3728 }
3725 }; 3729 };
3726 3730
3727 return { 3731 return {
3728 PodRow: PodRow 3732 PodRow: PodRow
3729 }; 3733 };
3730 }); 3734 });
OLDNEW
« no previous file with comments | « chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698