Don't focus the location bar for NTP navigations in non-selected tabs.

chrome/browser/ui/browser_focus_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/format_macros.h"
 #include "base/location.h"
@@ skipping 27 matching lines @@
 #include "components/omnibox/browser/omnibox_view.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/interstitial_page_delegate.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_navigation_observer.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 #if defined(OS_WIN)
 #include "base/win/windows_version.h"
 #endif
 
 using content::RenderViewHost;
 using content::WebContents;
 
 namespace {
@@ skipping 673 matching lines @@
 
   ASSERT_TRUE(content::ExecuteScript(web_contents, spoof));
   EXPECT_EQ(url1, web_contents->GetVisibleURL());
   // After running the spoof code, |GetActiveWebContents| returns the new tab,
   // not the same as |web_contents|.
   ASSERT_NO_FATAL_FAILURE(content::WaitForLoadStop(
       browser()->tab_strip_model()->GetActiveWebContents()));
   EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX));
 }
 
+// Regression test for https://crbug.com/677716.  This ensures that the omnibox
+// does not get focused if another tab in the same window navigates to the New
+// Tab Page, since that can scroll the origin of the selected tab out of view.
+IN_PROC_BROWSER_TEST_F(BrowserFocusTest, NoFocusForBackgroundNTP) {
+  // Start at the NTP and navigate to a test page.  We will later go back to the
+  // NTP, which gives the omnibox focus in some cases.
+  chrome::NewTab(browser());
+  const GURL url1(embedded_test_server()->GetURL("/title1.html"));

[Peter Kasting, 2017/01/12 18:24:04]

Nit: Prefer = to () for initializing things like GURLs and strings; see
https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Variab...
.  (several places)

Personally, for things like "url1" where the name is not much clearer than
seeing the code used to initialize this, I'd just inline the initializer into
the usage below directly, unless things are longer overall that way.  But up to
you.

[Charlie Reis, 2017/01/12 19:26:54]

Thanks, done.  I updated the source of the pattern (i.e., test above) as well.

+  ui_test_utils::NavigateToURL(browser(), url1);
+
+  TabStripModel* tab_strip = browser()->tab_strip_model();
+  WebContents* opener_web_contents = tab_strip->GetActiveWebContents();
+
+  // Open a second tab from the test page.
+  const GURL url2(embedded_test_server()->GetURL("/title2.html"));
+  const std::string open_script("window.open('" + url2.spec() + "');");
+  content::WebContentsAddedObserver open_observer;
+  ASSERT_TRUE(content::ExecuteScript(opener_web_contents, open_script));
+  WebContents* new_web_contents = open_observer.GetWebContents();
+
+  // Tell the first (non-selected) tab to go back.  This should not give the
+  // omnibox focus, since the navigation occurred in a different tab.  Otherwise
+  // the focus may scroll the origin out of view, making a spoof possible.
+  const std::string go_back_script("window.opener.history.back();");
+  content::TestNavigationObserver back_observer(opener_web_contents);
+  ASSERT_TRUE(content::ExecuteScript(new_web_contents, go_back_script));
+  back_observer.Wait();
+  EXPECT_FALSE(IsViewFocused(VIEW_ID_OMNIBOX));
+}
+
 }  // namespace