Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: headless/app/headless_shell.cc

Issue 2624343002: Get headless_shell building on Windows. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/app/headless_shell.cc
diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc
index 6c28e708eb92cd6624d71fb9692c44e528227046..5ab7e9e6d4c90852e31c4fbd0f28724084743bdc 100644
--- a/headless/app/headless_shell.cc
+++ b/headless/app/headless_shell.cc
@@ -106,8 +106,8 @@ class HeadlessShell : public HeadlessWebContents::Observer,
// TODO(alexclarke): Should we navigate to about:blank first if using
// virtual time?
- if (args.empty())
- args.push_back("about:blank");
+ //if (args.empty())
dvallet 2017/02/13 03:20:24 These is no longer needed
+ // args.push_back("about:blank");
for (auto it = args.rbegin(); it != args.rend(); ++it) {
GURL url(*it);
HeadlessWebContents* web_contents = builder.SetInitialURL(url).Build();
@@ -446,7 +446,9 @@ int HeadlessShellMain(int argc, const char** argv) {
HeadlessBrowser::Options::Builder builder(argc, argv);
// Enable devtools if requested.
- base::CommandLine command_line(argc, argv);
+ base::CommandLine::Init(0, nullptr);
dvallet 2017/02/13 03:20:24 Ditto, this is not needed anymore
+
+ const base::CommandLine& command_line = *base::CommandLine::ForCurrentProcess();
if (!ValidateCommandLine(command_line))
return EXIT_FAILURE;

Powered by Google App Engine
This is Rietveld 408576698