Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2523)

Unified Diff: ash/wm/maximize_mode/maximize_mode_window_manager.cc

Issue 262433002: Exit overview before exiting maximize mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/maximize_mode/maximize_mode_window_manager.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager.cc b/ash/wm/maximize_mode/maximize_mode_window_manager.cc
index 964f77a10c8017570e70fc9774297fe507f8e200..634cfb2c98c23c38af822b22fd4413efb047e877 100644
--- a/ash/wm/maximize_mode/maximize_mode_window_manager.cc
+++ b/ash/wm/maximize_mode/maximize_mode_window_manager.cc
@@ -19,6 +19,13 @@
namespace ash {
MaximizeModeWindowManager::~MaximizeModeWindowManager() {
+ // Overview mode needs to be ended before exiting maximize mode to prevent
+ // transforming windows which are currently in
+ // overview: http://crbug.com/366605
+ WindowSelectorController* controller =
+ Shell::GetInstance()->window_selector_controller();
+ if (controller && controller->IsSelecting())
+ controller->OnSelectionCanceled();
Mr4D (OOO till 08-26) 2014/04/29 19:45:21 Could you put that into a utility function (maybe
flackr 2014/04/29 20:56:10 Done.
Shell::GetInstance()->RemoveShellObserver(this);
Shell::GetScreen()->RemoveObserver(this);
EnableBackdropBehindTopWindowOnEachDisplay(false);
« no previous file with comments | « no previous file | ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698