Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262433002: Exit overview before exiting maximize mode. (Closed)

Created:
6 years, 7 months ago by flackr
Modified:
6 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Exit overview before exiting maximize mode. BUG=366605 TEST=MaximizeModeWindowManagerTest.ExitsOverview TEST=Enter maximize mode, enter overview, exit maximize mode. Overview should have exited on exiting maximize mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267122

Patch Set 1 #

Total comments: 2

Patch Set 2 : Create utility function to cancel overview. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 1 2 chunks +18 lines, -4 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
flackr
Please take a look, thanks!
6 years, 7 months ago (2014-04-29 18:23:50 UTC) #1
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/262433002/diff/1/ash/wm/maximize_mode/maximize_mode_window_manager.cc File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right): https://codereview.chromium.org/262433002/diff/1/ash/wm/maximize_mode/maximize_mode_window_manager.cc#newcode28 ash/wm/maximize_mode/maximize_mode_window_manager.cc:28: controller->OnSelectionCanceled(); Could you put that into a utility ...
6 years, 7 months ago (2014-04-29 19:45:20 UTC) #2
flackr
https://codereview.chromium.org/262433002/diff/1/ash/wm/maximize_mode/maximize_mode_window_manager.cc File ash/wm/maximize_mode/maximize_mode_window_manager.cc (right): https://codereview.chromium.org/262433002/diff/1/ash/wm/maximize_mode/maximize_mode_window_manager.cc#newcode28 ash/wm/maximize_mode/maximize_mode_window_manager.cc:28: controller->OnSelectionCanceled(); On 2014/04/29 19:45:21, Mr4D wrote: > Could you ...
6 years, 7 months ago (2014-04-29 20:56:09 UTC) #3
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 7 months ago (2014-04-29 20:56:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/262433002/20001
6 years, 7 months ago (2014-04-29 20:58:49 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:49:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:49:57 UTC) #7
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 7 months ago (2014-04-29 21:51:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/262433002/20001
6 years, 7 months ago (2014-04-29 21:57:39 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:19:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:19:06 UTC) #11
flackr
The CQ bit was checked by flackr@chromium.org
6 years, 7 months ago (2014-04-30 03:51:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/262433002/20001
6 years, 7 months ago (2014-04-30 03:53:39 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 07:31:03 UTC) #14
Message was sent while issue was closed. 
Change committed as 267122

Powered by Google App Engine
This is Rietveld 408576698