Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 26243003: Enable EncryptedMediaTest (in content_browsertests) on Android. (Closed)

Created:
7 years, 2 months ago by xhwang
Modified:
7 years, 2 months ago
Reviewers:
ddorwin, shadi
CC:
chromium-reviews, craigdh+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, darin-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, qinmin
Visibility:
Public.

Description

Enable EncryptedMediaTest (in content_browsertests) on Android. Encrytped media playback with <video src=...> is not supported on Android. Those tests will not run on Android. BUG=304956, 300035 TEST=This CL enables tests which was previously disabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227565

Patch Set 1 #

Patch Set 2 : reupload #

Total comments: 5

Patch Set 3 : address comments #

Patch Set 4 : address comments #

Patch Set 5 : reupload again #

Patch Set 6 : upload again.... #

Patch Set 7 : rebase only #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 2 3 4 5 6 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
xhwang
ddorwin/shadi: PTAL qinmin: FYI https://codereview.chromium.org/26243003/diff/4001/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/26243003/diff/4001/content/browser/media/encrypted_media_browsertest.cc#newcode111 content/browser/media/encrypted_media_browsertest.cc:111: INSTANTIATE_TEST_CASE_P(MSE_ClearKey, EncryptedMediaTest, I prefix the ...
7 years, 2 months ago (2013-10-07 21:41:22 UTC) #1
ddorwin
lgtm % comments https://codereview.chromium.org/26243003/diff/4001/content/browser/media/encrypted_media_browsertest.cc File content/browser/media/encrypted_media_browsertest.cc (right): https://codereview.chromium.org/26243003/diff/4001/content/browser/media/encrypted_media_browsertest.cc#newcode106 content/browser/media/encrypted_media_browsertest.cc:106: // TODO(xhwang): Encrypted media playback with ...
7 years, 2 months ago (2013-10-07 21:46:21 UTC) #2
shadi
LGTM Thanks!
7 years, 2 months ago (2013-10-07 22:01:56 UTC) #3
xhwang
Comments addressed. The side-by-side view still shows "bad old chunk" even if I tried to ...
7 years, 2 months ago (2013-10-07 22:05:24 UTC) #4
ddorwin
lgtm
7 years, 2 months ago (2013-10-07 22:07:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/26243003/24001
7 years, 2 months ago (2013-10-08 07:20:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=86654
7 years, 2 months ago (2013-10-08 17:53:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/26243003/24001
7 years, 2 months ago (2013-10-08 18:02:42 UTC) #8
commit-bot: I haz the power
Change committed as 227565
7 years, 2 months ago (2013-10-08 19:23:07 UTC) #9
frankf
7 years, 2 months ago (2013-10-08 23:56:52 UTC) #10
Message was sent while issue was closed.
On 2013/10/08 19:23:07, I haz the power (commit-bot) wrote:
> Change committed as 227565

These tests are failing:
http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28ICS%20...

I reverted this CL. Note that content_browsertests only run on android_fyi_dbg
trybots which you didn't run.

Powered by Google App Engine
This is Rietveld 408576698