Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2624283004: Associate a main resource request with its PageLoadTracker. (Closed)
Patch Set: fix comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index 76124a26369d7e0452976fcfa4ff0411d42bb71d..1586b63a606c39ae50adb03ec02ac6281b8809c2 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -49,6 +49,7 @@ class PageLoadMetricsBrowserTest : public InProcessBrowserTest {
base::HistogramTester histogram_tester_;
+ private:
DISALLOW_COPY_AND_ASSIGN(PageLoadMetricsBrowserTest);
};
@@ -85,6 +86,7 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, NewPage) {
internal::kHistogramParseBlockedOnScriptLoad, 1);
histogram_tester_.ExpectTotalCount(
internal::kHistogramParseBlockedOnScriptExecution, 1);
+ histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1);
// Verify that NoPageLoadMetricsRecorded returns false when PageLoad metrics
// have been recorded.
@@ -549,3 +551,17 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, CSSTiming) {
histogram_tester_.ExpectTotalCount(
"PageLoad.CSSTiming.ParseAndUpdate.BeforeFirstContentfulPaint", 1);
}
+
+IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest, PayloadSize) {
+ ASSERT_TRUE(embedded_test_server()->Start());
+
+ ui_test_utils::NavigateToURL(browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/large.html"));
+ NavigateToUntrackedUrl();
+
+ histogram_tester_.ExpectTotalCount(internal::kHistogramTotalBytes, 1);
+
+ // Verify that there is a single sample recorded in the 10kB bucket (the size
+ // of the main HTML response).
+ histogram_tester_.ExpectBucketCount(internal::kHistogramTotalBytes, 10, 1);
+}

Powered by Google App Engine
This is Rietveld 408576698