Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2624273002: VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector (Closed)

Created:
3 years, 11 months ago by kustermann
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: [Kernel] Fix constructor invocations by creating the unfolded type argument vector R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/1c7c3408bf991d1dcf7693397e81c9bf9cb2081c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -33 lines) Patch
M runtime/vm/kernel_to_il.cc View 1 chunk +14 lines, -19 lines 1 comment Download
M tests/co19/co19-kernel.status View 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_kernel.status View 4 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kustermann
https://codereview.chromium.org/2624273002/diff/1/runtime/vm/kernel_to_il.cc File runtime/vm/kernel_to_il.cc (left): https://codereview.chromium.org/2624273002/diff/1/runtime/vm/kernel_to_il.cc#oldcode4581 runtime/vm/kernel_to_il.cc:4581: instructions += TranslateInstantiatedTypeArguments(type_arguments); This CL replaces if () { ...
3 years, 11 months ago (2017-01-11 19:16:37 UTC) #2
Vyacheslav Egorov (Google)
lgtm
3 years, 11 months ago (2017-01-11 19:23:05 UTC) #3
kustermann
3 years, 11 months ago (2017-01-11 19:24:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1c7c3408bf991d1dcf7693397e81c9bf9cb2081c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698