Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: media/mojo/interfaces/audio_decoder.mojom

Issue 2624213006: media: Fix MojoAudioDecoder reinitialization (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/interfaces/audio_decoder.mojom
diff --git a/media/mojo/interfaces/audio_decoder.mojom b/media/mojo/interfaces/audio_decoder.mojom
index 9833aeea6470076af604e704add20350d2969c15..4ee086b0df27b00a59004710727c66fc15a8debe 100644
--- a/media/mojo/interfaces/audio_decoder.mojom
+++ b/media/mojo/interfaces/audio_decoder.mojom
@@ -7,12 +7,18 @@ module media.mojom;
import "media/mojo/interfaces/media_types.mojom";
interface AudioDecoder {
+ // Initialize the decoder. This must be called before any other method.
+ //
+ // TODO(sandersd): Rename to Initialize() if/when
+ // media::AudioDecoder::Initialize() is renamed to Configure().
+ Construct(associated AudioDecoderClient client);
+
// Initializes the AudioDecoder with the audio codec configuration and CDM id.
// For the unencrypted streams the |cdm_id| is ignored. Executed the callback
// with whether the initialization succeeded, and whether the pipeline needs
// bitstream conversion.
- Initialize(associated AudioDecoderClient client, AudioDecoderConfig config,
- int32 cdm_id) => (bool success, bool needs_bitstream_conversion);
+ Initialize(AudioDecoderConfig config, int32 cdm_id)
+ => (bool success, bool needs_bitstream_conversion);
// Establishes data connection. Should be called before Decode().
SetDataSource(handle<data_pipe_consumer> receive_pipe);

Powered by Google App Engine
This is Rietveld 408576698