Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 2624193004: Submit a sample of notification images to Safe Browsing (Closed)
Patch Set: Add basic success test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_impl.cc
diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc
index 25bcadda2b810d5519e694e293e97e3dee28e966..12a37d02e895b0383706d33201fd532a5147bfd1 100644
--- a/chrome/browser/notifications/platform_notification_service_impl.cc
+++ b/chrome/browser/notifications/platform_notification_service_impl.cc
@@ -21,6 +21,8 @@
#include "chrome/browser/profiles/profile_attributes_storage.h"
#include "chrome/browser/profiles/profile_io_data.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/safe_browsing/ping_manager.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/common/pref_names.h"
#include "chrome/grit/generated_resources.h"
@@ -36,6 +38,7 @@
#include "content/public/common/notification_resources.h"
#include "content/public/common/platform_notification_data.h"
#include "extensions/features/features.h"
+#include "third_party/skia/include/core/SkBitmap.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/message_center/notification.h"
@@ -87,6 +90,18 @@ void CancelNotification(const std::string& notification_id,
notification_id));
}
+void ReportNotificationImageOnIOThread(
+ scoped_refptr<safe_browsing::SafeBrowsingService> safe_browsing_service,
+ Profile* profile,
+ const GURL& origin,
+ const SkBitmap& image) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ if (!safe_browsing_service || !safe_browsing_service->enabled())
+ return;
+ safe_browsing_service->ping_manager()->ReportNotificationImage(profile,
+ origin, image);
+}
+
} // namespace
// static
@@ -428,6 +443,13 @@ Notification PlatformNotificationServiceImpl::CreateNotificationFromData(
notification.set_type(message_center::NOTIFICATION_TYPE_IMAGE);
notification.set_image(
gfx::Image::CreateFrom1xBitmap(notification_resources.image));
+ // n.b. this should only be posted once per notification.
+ BrowserThread::PostTask(
+ BrowserThread::IO, FROM_HERE,
+ base::Bind(
+ &ReportNotificationImageOnIOThread,
+ make_scoped_refptr(g_browser_process->safe_browsing_service()),
+ profile, origin, notification_resources.image));
}
// Badges are only supported on Android, primarily because it's the only

Powered by Google App Engine
This is Rietveld 408576698