Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/safe_browsing/notification_image_reporter.h

Issue 2624193004: Submit a sample of notification images to Safe Browsing (Closed)
Patch Set: Address peter's review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/notification_image_reporter.h
diff --git a/chrome/browser/safe_browsing/notification_image_reporter.h b/chrome/browser/safe_browsing/notification_image_reporter.h
new file mode 100644
index 0000000000000000000000000000000000000000..ba64a31eb3f79cbc689d10c21ac3ae9c82dd334a
--- /dev/null
+++ b/chrome/browser/safe_browsing/notification_image_reporter.h
@@ -0,0 +1,83 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_IMAGE_REPORTER_H_
+#define CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_IMAGE_REPORTER_H_
+
+#include <memory>
+#include <queue>
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/time/time.h"
+
+class GURL;
+class Profile;
+class SkBitmap;
+
+namespace base {
+class RefCountedMemory;
+} // namespace base
+
+namespace gfx {
+class Size;
+} // namespace gfx
+
+namespace net {
+class ReportSender;
+class URLRequestContext;
+} // namespace net
+
+namespace safe_browsing {
+
+class SafeBrowsingService;
+
+// Provides functionality for building and sending reports about notification
+// content images to the Safe Browsing CSD server.
+class NotificationImageReporter
+ : public base::RefCountedThreadSafe<NotificationImageReporter> {
+ public:
+ explicit NotificationImageReporter(net::URLRequestContext* request_context);
+
+ // Report notification content image to SafeBrowsing CSD server if the user
+ // has opted in, the origin is not whitelisted, and it is randomly sampled.
+ // Can only be called on UI thread.
+ void ReportNotificationImageOnUI(Profile* profile,
+ const GURL& origin,
+ const SkBitmap& image);
+
+ private:
+ friend class base::RefCountedThreadSafe<NotificationImageReporter>;
+ ~NotificationImageReporter();
+
+ // Report notification content image to SafeBrowsing CSD server if necessary.
+ void ReportNotificationImageOnIO(
+ scoped_refptr<SafeBrowsingService> safe_browsing_service,
+ const GURL& origin,
+ const SkBitmap& image);
+
+ // Downscales image to fit within 512x512 if necessary, and encodes as it PNG.
+ void DownscaleNotificationImageOnBlockingPool(const GURL& origin,
Nathan Parker 2017/01/11 22:34:38 What's the output of this? (i.e. does it invoke Se
johnme 2017/01/13 02:38:17 Done.
+ const SkBitmap& image);
+
+ // Serializes report using NotificationImageReportRequest protobuf defined in
+ // chrome/common/safe_browsing/csd.proto and sends it to CSD server.
+ void SendReportOnIO(const GURL& origin,
+ scoped_refptr<base::RefCountedMemory> png_data,
+ const gfx::Size& dimensions,
+ const gfx::Size& original_dimensions);
+
+ std::unique_ptr<net::ReportSender> report_sender_;
+
+ // Timestamps of when we sent notification images. Used to limit the number
+ // of requests that we send in a day. Only access on the IO thread.
+ // TODO(johnme): Serialize this so that it doesn't reset on browser restart.
+ std::queue<base::Time> report_times_;
+
+ DISALLOW_COPY_AND_ASSIGN(NotificationImageReporter);
+};
+
+} // namespace safe_browsing
+
+#endif // CHROME_BROWSER_SAFE_BROWSING_NOTIFICATION_IMAGE_REPORTER_H_

Powered by Google App Engine
This is Rietveld 408576698