chrome/browser/notifications/platform_notification_service_impl.h - Issue 2624193004: Submit a sample of notification images to Safe Browsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.h

Issue 2624193004: Submit a sample of notification images to Safe Browsing (Closed)

Patch Set: Report net_error codes to UMA Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/platform_notification_service_impl.h

diff --git a/chrome/browser/notifications/platform_notification_service_impl.h b/chrome/browser/notifications/platform_notification_service_impl.h

index feb64404a4407125e87a1e3446b744b419287896..12c6e6181d4190459646c7b7af238fdfbf00576a 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.h

+++ b/chrome/browser/notifications/platform_notification_service_impl.h

@@ -119,7 +119,8 @@ class PlatformNotificationServiceImpl

void OnCloseEventDispatchComplete(

content::PersistentNotificationStatus status);

- // Creates a new Web Notification-based Notification object.

+ // Creates a new Web Notification-based Notification object. Should only be

+ // called when the notification is first shown.

// TODO(peter): |delegate| can be a scoped_refptr, but properly passing this

// through requires changing a whole lot of Notification constructor calls.

Notification CreateNotificationFromData(