Scroll to make the selected IME visible.

ash/common/system/chromeos/ime_menu/ime_list_view.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be

[tdanderson, 2017/01/12 00:16:15]

Did you manually verify this on both the opt-in IME menu and the IME detailed
view?

[Azure Wei, 2017/01/12 01:20:54]

This CL only works with opt-in IME menu. For IME detailed, ImeListView could not
get event like VisibilityChanged() event, I'm still working on it.

[tdanderson, 2017/01/12 21:27:33]

I would strongly prefer a solution which worked for both the opt-in menu as well
as the IME detailed view, rather than coming up with two separate solutions.

A more general approach to solving this could be to have both surfaces listen
for any time the current IME changes (e.g., whatever logic changes the IME in
response to Ctrl+Shift+Space would invoke OnIMEChanged() or similar on its
listeners - such an interface may already exist). Once invoked, you could call
ScrollRectToVisible() on the current IME.

Please spend a bit of time and see if you can come up with any ideas here and
let me know. If you don't have any luck then I can take another look at this CL
tomorrow and we can land it for just the opt-in menu. All things considered, I
don't think that using Ctrl+Shift+Space *while* the IME menu is open would be a
particularly important use case; it seems the benefit of Ctrl+Shift+Space is
that it can be used as a very quick way of switching between IMEs without
needing to open any menus.

 // found in the LICENSE file.
 
 #ifndef ASH_COMMON_SYSTEM_CHROMEOS_IME_MENU_IME_LIST_VIEW_H_
 #define ASH_COMMON_SYSTEM_CHROMEOS_IME_MENU_IME_LIST_VIEW_H_
 
 #include "ash/common/system/tray/ime_info.h"
 #include "ash/common/system/tray/tray_details_view.h"
 #include "ui/views/controls/button/button.h"
 
 namespace ash {
@@ skipping 39 matching lines @@
 
   bool should_focus_ime_after_selection_with_keyboard() const {
     return should_focus_ime_after_selection_with_keyboard_;
   }
 
   // TrayDetailsView:
   void HandleViewClicked(views::View* view) override;
   void HandleButtonPressed(views::Button* sender,
                            const ui::Event& event) override;
 
+  // views::View:
+  void VisibilityChanged(View* starting_from, bool is_visible) override;
+
  private:
   // To allow the test class to access |ime_map_|.
   friend class ImeMenuTrayTest;
 
   // Appends the IMEs to the scrollable area of the detailed view.
   void AppendIMEList(const IMEInfoList& list);
 
   // Appends the IME listed to the scrollable area of the detailed view.
   void AppendIMEProperties(const IMEPropertyInfoList& property_list);
 
@@ skipping 24 matching lines @@
   // item is not selected with keyboard.
   std::string last_selected_item_id_;
 
   // True if the last item is selected with keyboard.
   bool last_item_selected_with_keyboard_;
 
   // True if focus should be requested after switching IMEs with keyboard in
   // order to trigger spoken feedback with ChromeVox enabled.
   bool should_focus_ime_after_selection_with_keyboard_;
 
+  // The item view of the current selected IME.
+  views::View* current_ime_view_;
+
   DISALLOW_COPY_AND_ASSIGN(ImeListView);
 };
 
 }  // namespace ash
 
 #endif  // ASH_COMMON_SYSTEM_CHROMEOS_IME_MENU_IME_LIST_VIEW_H_