base/timer/timer.h - Issue 2624133004: Fix use-after-free in base::Timer::StopAndAbandon()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/timer/timer.h

Issue 2624133004: Fix use-after-free in base::Timer::StopAndAbandon() (Closed)

Patch Set: Merge branch 'master' into timer_bug Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/timer/timer.h

diff --git a/base/timer/timer.h b/base/timer/timer.h

index 50aedbd4cec28e97c408b2acd8b896c70526732c..8aac279def647771f7cead12876c2ea06e4fddcf 100644

--- a/base/timer/timer.h

+++ b/base/timer/timer.h

@@ -163,8 +163,10 @@ class BASE_EXPORT Timer {

// Stop running task (if any) and abandon scheduled task (if any).

void StopAndAbandon() {

- Stop();

AbandonScheduledTask();

+ Stop();

+ // No more member accesses here: |this| could be deleted at this point.

}

// When non-NULL, the scheduled_task_ is waiting in the MessageLoop to call

« no previous file with comments | « no previous file | base/timer/timer_unittest.cc » ('j') | no next file with comments »