Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2624023002: Change test to work with app-snapshots. (Closed)

Created:
3 years, 11 months ago by Florian Schneider
Modified:
3 years, 11 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change test to work with app-snapshots. App snapshot don't contain column information. Change the expectation to only expect line numbers. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/d54341927ef5c12d885563065d27bdb4d755a5b1

Patch Set 1 #

Patch Set 2 : Update dartium status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tests/language/language.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/vm/regress_28325_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 11 months ago (2017-01-10 22:22:11 UTC) #2
hausner
LGTM
3 years, 11 months ago (2017-01-10 22:26:44 UTC) #3
Florian Schneider
3 years, 11 months ago (2017-01-10 22:29:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d54341927ef5c12d885563065d27bdb4d755a5b1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698