WebUI: Add cr-policy-pref-indicator tests

ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Behavior for policy controlled indicators.
  */
 
 /**
  * Strings required for policy indicators. These must be set at runtime.
@@ skipping 30 matching lines @@
     return type != CrPolicyIndicatorType.NONE &&
         type != CrPolicyIndicatorType.EXTENSION;
   },
 
   /**
    * @param {CrPolicyIndicatorType} type
    * @return {string} The iron-icon icon name.
    * @private
    */
   getPolicyIndicatorIcon: function(type) {
-    var icon = '';
+    var icon;
     switch (type) {
       case CrPolicyIndicatorType.EXTENSION:
       case CrPolicyIndicatorType.NONE:
-        return icon;
+        icon = 'domain';  // Set a valid icon for accessibility audit

[michaelpg, 2017/02/15 02:02:11]

why does the accessibility audit care if the element is hidden (which it should
be in this case, I thought)?

seems like having a real icon here could contribute to bugs (or accidentally
correct behavior) in the future

[stevenjb, 2017/02/15 02:23:29]

Turns out we don't need this any more, so nevermind.

+        break;
       case CrPolicyIndicatorType.PRIMARY_USER:
         icon = 'cr:group';
         break;
       case CrPolicyIndicatorType.OWNER:
         icon = 'cr:person';
         break;
       case CrPolicyIndicatorType.USER_POLICY:
       case CrPolicyIndicatorType.DEVICE_POLICY:
       case CrPolicyIndicatorType.RECOMMENDED:
         icon = 'cr20:domain';
         break;
       default:
         assertNotReached();
+        icon = '';  // For closure
     }
     return icon;
   },
 
   /**
-   * @param {CrPolicyIndicatorType} type
+   * @param {!CrPolicyIndicatorType} type
    * @param {string} name The name associated with the indicator. See
    *     chrome.settingsPrivate.PrefObject.controlledByName
    * @param {boolean=} opt_matches For RECOMMENDED only, whether the indicator
    *     value matches the recommended value.
    * @return {string} The tooltip text for |type|.
    */
   getPolicyIndicatorTooltip: function(type, name, opt_matches) {
     if (!CrPolicyStrings)
       return '';  // Tooltips may not be defined, e.g. in OOBE.
     switch (type) {
       case CrPolicyIndicatorType.PRIMARY_USER:
         return CrPolicyStrings.controlledSettingShared.replace('$1', name);
       case CrPolicyIndicatorType.OWNER:
         return CrPolicyStrings.controlledSettingOwner.replace('$1', name);
       case CrPolicyIndicatorType.USER_POLICY:
       case CrPolicyIndicatorType.DEVICE_POLICY:
         return CrPolicyStrings.controlledSettingPolicy;
       case CrPolicyIndicatorType.RECOMMENDED:
         return opt_matches ?
             CrPolicyStrings.controlledSettingRecommendedMatches :
             CrPolicyStrings.controlledSettingRecommendedDiffers;
     }
     return '';
   },
 };