Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3067)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2623993007: 🏠 Extract the ContentSuggestionManager interface from NTP (Closed)
Patch Set: fix destruction of snippets bridge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
index 15a6ffe2f6d49c7a8ab916bdd3fd98fa14287d0b..b30e68fe9e0679ddb50302a0a57136ed10fc6842 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java
@@ -15,8 +15,8 @@
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
+import org.chromium.chrome.browser.ntp.ContextMenuManager;
import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.preferences.ChromePreferenceManager;
import org.chromium.chrome.browser.signin.AccountSigninActivity;
@@ -24,6 +24,7 @@
import org.chromium.chrome.browser.signin.SigninManager;
import org.chromium.chrome.browser.signin.SigninManager.SignInAllowedObserver;
import org.chromium.chrome.browser.signin.SigninManager.SignInStateObserver;
+import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
/**
* Shows a card prompting the user to sign in. This item is also an {@link OptionalLeaf}, and sign
@@ -43,7 +44,7 @@
@Nullable
private final SigninObserver mObserver;
- public SignInPromo(NewTabPageManager newTabPageManager) {
+ public SignInPromo(SuggestionsUiDelegate uiDelegate) {
mDismissed = ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())
.getNewTabPageSigninPromoDismissed();
@@ -52,7 +53,7 @@ public SignInPromo(NewTabPageManager newTabPageManager) {
mObserver = null;
} else {
mObserver = new SigninObserver(signinManager);
- newTabPageManager.addDestructionObserver(mObserver);
+ uiDelegate.addDestructionObserver(mObserver);
}
setVisible(signinManager.isSignInAllowed() && !signinManager.isSignedInOnNative());
@@ -178,9 +179,9 @@ public void onSignedOut() {
public static class ViewHolder extends StatusCardViewHolder {
private final int mSeparationSpaceSize;
- public ViewHolder(NewTabPageRecyclerView parent, NewTabPageManager newTabPageManager,
+ public ViewHolder(NewTabPageRecyclerView parent, ContextMenuManager contextMenuManager,
UiConfig config) {
- super(parent, newTabPageManager, config);
+ super(parent, contextMenuManager, config);
mSeparationSpaceSize = parent.getResources().getDimensionPixelSize(
R.dimen.ntp_sign_in_promo_margin_top);
}

Powered by Google App Engine
This is Rietveld 408576698