Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2713)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2623993007: 🏠 Extract the ContentSuggestionManager interface from NTP (Closed)
Patch Set: aaaand rebase again Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index 34e6edc132616e5a8f1a5ae21dc96a88132431ea..786f126a4227239acb9a414cdb32c332b903a2c0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -12,11 +12,11 @@
import org.chromium.chrome.browser.ntp.ContextMenuManager;
import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.suggestions.SuggestionsRanker;
+import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -82,16 +82,16 @@ public int getPerSectionRank() {
}
@VisibleForTesting
- void performAction(NewTabPageManager manager) {
- manager.getSuggestionsMetricsReporter().onMoreButtonClicked(this);
+ void performAction(SuggestionsUiDelegate uiDelegate) {
+ uiDelegate.getMetricsReporter().onMoreButtonClicked(this);
switch (mCurrentAction) {
case ACTION_VIEW_ALL:
- mCategoryInfo.performViewAllAction(manager);
+ mCategoryInfo.performViewAllAction(uiDelegate.getNavigationDelegate());
return;
case ACTION_FETCH_MORE:
case ACTION_RELOAD:
- manager.getSuggestionsSource().fetchSuggestions(
+ uiDelegate.getSuggestionsSource().fetchSuggestions(
mCategoryInfo.getCategory(), mParentSection.getDisplayedSuggestionIds());
mParentSection.onFetchStarted();
return;
@@ -116,14 +116,15 @@ private int findAppropriateAction() {
private ActionItem mActionListItem;
public ViewHolder(final NewTabPageRecyclerView recyclerView,
- final NewTabPageManager manager, UiConfig uiConfig) {
- super(R.layout.new_tab_page_action_card, recyclerView, uiConfig, manager);
+ ContextMenuManager contextMenuManager, final SuggestionsUiDelegate uiDelegate,
+ UiConfig uiConfig) {
+ super(R.layout.new_tab_page_action_card, recyclerView, uiConfig, contextMenuManager);
itemView.findViewById(R.id.action_button)
.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
- mActionListItem.performAction(manager);
+ mActionListItem.performAction(uiDelegate);
}
});
@@ -132,7 +133,7 @@ public void onClick(View v) {
public void onImpression() {
if (mActionListItem != null && !mActionListItem.mImpressionTracked) {
mActionListItem.mImpressionTracked = true;
- manager.getSuggestionsMetricsReporter().onMoreButtonShown(mActionListItem);
+ uiDelegate.getMetricsReporter().onMoreButtonShown(mActionListItem);
}
}
});

Powered by Google App Engine
This is Rietveld 408576698