Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java

Issue 2623993007: 🏠 Extract the ContentSuggestionManager interface from NTP (Closed)
Patch Set: aaaand rebase again Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
index fa83ec031a42684fb8733393dde429f2980162f7..101a74c3cdf7a255d3379abe7516a72d4a9bee49 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuManager.java
@@ -14,9 +14,9 @@
import android.view.View;
import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
+import org.chromium.chrome.browser.suggestions.SuggestionsNavigationDelegate;
import org.chromium.ui.base.WindowAndroid.OnCloseContextMenuListener;
import org.chromium.ui.mojom.WindowOpenDisposition;
@@ -43,7 +43,7 @@
public static final int ID_REMOVE = 4;
private final Activity mActivity;
- private final NewTabPageManager mManager;
+ private final SuggestionsNavigationDelegate mNavigationDelegate;
private final TouchDisableableView mOuterView;
private boolean mContextMenuOpen;
@@ -71,10 +71,10 @@
/** Interface for a view that can be set to stop responding to touches. */
public interface TouchDisableableView { void setTouchEnabled(boolean enabled); }
- public ContextMenuManager(Activity activity, NewTabPageManager newTabPageManager,
+ public ContextMenuManager(Activity activity, SuggestionsNavigationDelegate navigationDelegate,
TouchDisableableView outerView) {
mActivity = activity;
- mManager = newTabPageManager;
+ mNavigationDelegate = navigationDelegate;
mOuterView = outerView;
}
@@ -140,11 +140,11 @@ private boolean shouldShowItem(@ContextMenuItemId int itemId, Delegate delegate)
switch (itemId) {
case ID_OPEN_IN_NEW_WINDOW:
- return mManager.isOpenInNewWindowEnabled();
+ return mNavigationDelegate.isOpenInNewWindowEnabled();
case ID_OPEN_IN_NEW_TAB:
return true;
case ID_OPEN_IN_INCOGNITO_TAB:
- return mManager.isOpenInIncognitoEnabled();
+ return mNavigationDelegate.isOpenInIncognitoEnabled();
case ID_SAVE_FOR_OFFLINE: {
if (!SnippetsConfig.isSaveToOfflineEnabled()) return false;
String itemUrl = delegate.getUrl();

Powered by Google App Engine
This is Rietveld 408576698