Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1829)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java

Issue 2623993007: 🏠 Extract the ContentSuggestionManager interface from NTP (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
index 71b7d4b494b5467d5516b4dd1e75fa1cd1ebb60c..97a50aa01265df76288ccbe1897fc874b6621843 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java
@@ -8,7 +8,6 @@
import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;
import org.chromium.chrome.browser.ntp.snippets.SectionHeader;
@@ -19,6 +18,7 @@
import org.chromium.chrome.browser.offlinepages.ClientId;
import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
import org.chromium.chrome.browser.offlinepages.OfflinePageItem;
+import org.chromium.chrome.browser.suggestions.ContentSuggestionsManager;
import java.util.ArrayList;
import java.util.Iterator;
@@ -52,7 +52,7 @@
void dismissSection(SuggestionsSection section);
}
- public SuggestionsSection(Delegate delegate, NewTabPageManager manager,
+ public SuggestionsSection(Delegate delegate, ContentSuggestionsManager manager,
OfflinePageBridge offlinePageBridge, SuggestionsCategoryInfo info) {
mDelegate = delegate;
mCategoryInfo = info;
@@ -71,12 +71,12 @@ public SuggestionsSection(Delegate delegate, NewTabPageManager manager,
private static class SuggestionsList extends ChildNode implements Iterable<SnippetArticle> {
private final List<SnippetArticle> mSuggestions = new ArrayList<>();
- private final NewTabPageManager mNewTabPageManager;
+ private final ContentSuggestionsManager mManager;
private final SuggestionsCategoryInfo mCategoryInfo;
- public SuggestionsList(NewTabPageManager newTabPageManager,
- SuggestionsCategoryInfo categoryInfo) {
- mNewTabPageManager = newTabPageManager;
+ public SuggestionsList(
+ ContentSuggestionsManager newTabPageManager, SuggestionsCategoryInfo categoryInfo) {
+ mManager = newTabPageManager;
mCategoryInfo = categoryInfo;
}
@@ -142,7 +142,7 @@ public SnippetArticle remove(int position) {
@Override
public void dismissItem(int position, Callback<String> itemRemovedCallback) {
checkIndex(position);
- SuggestionsSource suggestionsSource = mNewTabPageManager.getSuggestionsSource();
+ SuggestionsSource suggestionsSource = mManager.getSuggestionsSource();
if (suggestionsSource == null) {
// It is possible for this method to be called after the NewTabPage has had
// destroy() called. This can happen when
@@ -167,7 +167,7 @@ public void updateSuggestionOfflineId(SnippetArticle article, Long newId) {
}
}
- private void setupOfflinePageBridgeObserver(NewTabPageManager manager) {
+ private void setupOfflinePageBridgeObserver(ContentSuggestionsManager manager) {
final OfflinePageBridge.OfflinePageModelObserver observer =
new OfflinePageBridge.OfflinePageModelObserver() {
@Override

Powered by Google App Engine
This is Rietveld 408576698