Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2738)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java

Issue 2623993007: 🏠 Extract the ContentSuggestionManager interface from NTP (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
index a1a4e11875be3fdc3e182d8a25d15ffca6e2650b..ecd13aafdfd91ecd320e38aea8c4f40effaa1fad 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ActionItem.java
@@ -12,9 +12,9 @@
import org.chromium.chrome.browser.ntp.ContextMenuManager;
import org.chromium.chrome.browser.ntp.ContextMenuManager.ContextMenuItemId;
import org.chromium.chrome.browser.ntp.ContextMenuManager.Delegate;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
import org.chromium.chrome.browser.ntp.UiConfig;
import org.chromium.chrome.browser.ntp.snippets.SnippetsConfig;
+import org.chromium.chrome.browser.suggestions.ContentSuggestionsManager;
import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;
@@ -68,7 +68,7 @@ private int getPosition() {
}
@VisibleForTesting
- void performAction(NewTabPageManager manager) {
+ void performAction(ContentSuggestionsManager manager) {
manager.trackSnippetCategoryActionClick(mCategoryInfo.getCategory(), getPosition());
switch (mCurrentAction) {
@@ -101,8 +101,9 @@ private int findAppropriateAction() {
private ActionItem mActionListItem;
public ViewHolder(final NewTabPageRecyclerView recyclerView,
- final NewTabPageManager manager, UiConfig uiConfig) {
- super(R.layout.new_tab_page_action_card, recyclerView, uiConfig, manager);
+ ContextMenuManager contextMenuManager, final ContentSuggestionsManager manager,
+ UiConfig uiConfig) {
+ super(R.layout.new_tab_page_action_card, recyclerView, uiConfig, contextMenuManager);
itemView.findViewById(R.id.action_button)
.setOnClickListener(new View.OnClickListener() {

Powered by Google App Engine
This is Rietveld 408576698