🏠 Extract the ContentSuggestionManager interface from NTP

chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.cards;
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.junit.Assert.assertThat;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
 import static org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.createDummySuggestions;
 import static org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.registerCategory;
 
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
 import org.robolectric.annotation.Config;
 
 import org.chromium.base.Callback;
 import org.chromium.base.test.util.Feature;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
 import org.chromium.chrome.browser.ntp.cards.ContentSuggestionsTestUtils.CategoryInfoBuilder;
 import org.chromium.chrome.browser.ntp.snippets.CategoryInt;
 import org.chromium.chrome.browser.ntp.snippets.FakeSuggestionsSource;
 import org.chromium.chrome.browser.ntp.snippets.KnownCategories;
 import org.chromium.chrome.browser.ntp.snippets.SectionHeaderViewHolder;
 import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;
 import org.chromium.chrome.browser.ntp.snippets.SnippetArticleViewHolder;
 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
 import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
+import org.chromium.chrome.browser.suggestions.SuggestionsUiDelegate;
 import org.chromium.testing.local.LocalRobolectricTestRunner;
 
 import java.util.Collections;
 import java.util.List;
 
 /**
  * Unit tests for {@link SuggestionsSection}.
  */
 @RunWith(LocalRobolectricTestRunner.class)
 @Config(manifest = Config.NONE)
 public class SectionListTest {
     @Mock
-    private NewTabPageManager mNtpManager;
+    private SuggestionsUiDelegate mUiDelegate;
     @Mock
     private OfflinePageBridge mOfflinePageBridge;
     @Mock
     private SuggestionsMetricsReporter mMetricsReporter;
     private FakeSuggestionsSource mSuggestionSource;
 
     @Before
     public void setUp() {
         MockitoAnnotations.initMocks(this);
         mSuggestionSource = new FakeSuggestionsSource();
 
-        when(mNtpManager.getSuggestionsSource()).thenReturn(mSuggestionSource);
-        when(mNtpManager.getSuggestionsMetricsReporter()).thenReturn(mMetricsReporter);
+        when(mUiDelegate.getSuggestionsSource()).thenReturn(mSuggestionSource);
+        when(mUiDelegate.getMetricsReporter()).thenReturn(mMetricsReporter);
     }
 
     @Test
     @Feature({"Ntp"})
     public void testGetSuggestionRank() {
         // Setup the section list the following way:
         //
         //  Item type | local rank | global rank
         // -----------+------------+-------------
         // HEADER     |            |
         // ARTICLE    | 0          | 0
         // ARTICLE    | 1          | 1
         // ARTICLE    | 2          | 2
         // HEADER     |            |
         // STATUS     |            |
         // ACTION     | 0          |
         // BOOKMARK   | 0          | 3
         // BOOKMARK   | 1          | 4
         // BOOKMARK   | 2          | 5
         // BOOKMARK   | 3          | 6
         List<SnippetArticle> articles =
                 registerCategory(mSuggestionSource, KnownCategories.ARTICLES, 3);
         registerCategory(mSuggestionSource, KnownCategories.DOWNLOADS, 0);
         List<SnippetArticle> bookmarks =
                 registerCategory(mSuggestionSource, KnownCategories.BOOKMARKS, 4);
 
-        SectionList sectionList = new SectionList(mNtpManager, mOfflinePageBridge);
+        SectionList sectionList = new SectionList(mUiDelegate, mOfflinePageBridge);
 
         bindViewHolders(sectionList);
 
         assertThat(articles.get(0).getGlobalRank(), equalTo(0));
         assertThat(articles.get(0).getPerSectionRank(), equalTo(0));
         assertThat(articles.get(2).getGlobalRank(), equalTo(2));
         assertThat(articles.get(2).getPerSectionRank(), equalTo(2));
         assertThat(bookmarks.get(1).getGlobalRank(), equalTo(4));
         assertThat(bookmarks.get(1).getPerSectionRank(), equalTo(1));
     }
@@ skipping 15 matching lines @@
         // BOOKMARK   | 0          | 3
         // BOOKMARK   | 1          | 4
         // BOOKMARK   | 2          | 5
         // BOOKMARK   | 3          | 6
         List<SnippetArticle> articles =
                 registerCategory(mSuggestionSource, KnownCategories.ARTICLES, 3);
         registerCategory(mSuggestionSource, KnownCategories.DOWNLOADS, 0);
         List<SnippetArticle> bookmarks =
                 registerCategory(mSuggestionSource, KnownCategories.BOOKMARKS, 4);
 
-        SectionList sectionList = new SectionList(mNtpManager, mOfflinePageBridge);
+        SectionList sectionList = new SectionList(mUiDelegate, mOfflinePageBridge);
 
         bindViewHolders(sectionList, 0, 5); // Bind until after the third article.
 
         assertThat(articles.get(0).getGlobalRank(), equalTo(0));
         assertThat(articles.get(0).getPerSectionRank(), equalTo(0));
         assertThat(articles.get(2).getGlobalRank(), equalTo(2));
         assertThat(articles.get(2).getPerSectionRank(), equalTo(2));
         assertThat(bookmarks.get(1).getGlobalRank(), equalTo(-1));  // Not bound nor ranked yet.
         assertThat(bookmarks.get(1).getPerSectionRank(), equalTo(-1));
 
@@ skipping 79 matching lines @@
         assertThat(newArticles.get(1).getPerSectionRank(), equalTo(4));
     }
 
     @Test
     @Feature({"Ntp"})
     public void testGetActionItemRank() {
         registerCategory(mSuggestionSource, KnownCategories.ARTICLES, 0);
         registerCategory(mSuggestionSource,
                 new CategoryInfoBuilder(KnownCategories.DOWNLOADS).withViewAllAction().build(), 3);
 
-        SectionList sectionList = new SectionList(mNtpManager, mOfflinePageBridge);
+        SectionList sectionList = new SectionList(mUiDelegate, mOfflinePageBridge);
         bindViewHolders(sectionList);
 
         assertThat(sectionList.getSectionForTesting(KnownCategories.ARTICLES)
                            .getActionItem()
                            .getPerSectionRank(),
                 equalTo(0));
         assertThat(sectionList.getSectionForTesting(KnownCategories.DOWNLOADS)
                            .getActionItem()
                            .getPerSectionRank(),
                 equalTo(3));
@@ skipping 20 matching lines @@
                 return mock(StatusCardViewHolder.class);
             case ItemViewType.ACTION:
                 return mock(ActionItem.ViewHolder.class);
             case ItemViewType.PROGRESS:
                 return mock(ProgressViewHolder.class);
             default:
                 return mock(NewTabPageViewHolder.class);
         }
     }
 }