🏠 Extract the ContentSuggestionManager interface from NTP

chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.ntp.cards;
 
 import android.support.annotation.CallSuper;
 import android.support.annotation.DrawableRes;
 import android.support.annotation.Nullable;
 import android.support.v4.view.animation.FastOutSlowInInterpolator;
 import android.support.v7.widget.RecyclerView;
 import android.view.ContextMenu;
 import android.view.ContextMenu.ContextMenuInfo;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.View.OnAttachStateChangeListener;
 import android.view.View.OnClickListener;
 import android.view.ViewGroup;
 import android.view.animation.Interpolator;
 
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.ntp.ContextMenuManager;
-import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
 import org.chromium.chrome.browser.ntp.UiConfig;
 import org.chromium.chrome.browser.util.MathUtils;
 import org.chromium.chrome.browser.util.ViewUtils;
 
 /**
  * Holder for a generic card.
  *
  * Specific behaviors added to the cards:
  *
  * - Cards can peek above the fold if there is enough space.
@@ skipping 18 matching lines @@
      * Due to the card background being a 9 patch file - the card border shadow will be part of
      * the card width and height. This value will be used to adjust values to account for the
      * borders.
      */
     private final int mCards9PatchAdjustment;
 
     protected final NewTabPageRecyclerView mRecyclerView;
 
     private final UiConfig mUiConfig;
     private final MarginResizer mMarginResizer;
-    private final NewTabPageManager mNtpManager;
 
     /**
      * To what extent the card is "peeking". 0 means the card is not peeking at all and spans the
      * full width of its parent. 1 means it is fully peeking and will be shown with a margin.
      */
     private float mPeekingPercentage;
 
     @DrawableRes
     private int mBackground;
 
     /**
      * @param layoutId resource id of the layout to inflate and to use as card.
      * @param recyclerView ViewGroup that will contain the newly created view.
      * @param uiConfig The NTP UI configuration object used to adjust the card UI.
+     * @param contextMenuManager The manager responsible for the context menu.
      */
     public CardViewHolder(int layoutId, final NewTabPageRecyclerView recyclerView,
-            UiConfig uiConfig, NewTabPageManager ntpManager) {
+            UiConfig uiConfig, final ContextMenuManager contextMenuManager) {
         super(inflateView(layoutId, recyclerView));
 
         mCards9PatchAdjustment = recyclerView.getResources().getDimensionPixelSize(
                 R.dimen.snippets_card_9_patch_adjustment);
 
         mMaxPeekPadding = recyclerView.getResources().getDimensionPixelSize(
                 R.dimen.snippets_padding);
 
         mRecyclerView = recyclerView;
 
         itemView.setOnClickListener(new OnClickListener() {
             @Override
             public void onClick(View v) {
                 if (isPeeking()) {
                     recyclerView.scrollToFirstCard();
                 } else {
                     onCardTapped();
                 }
             }
         });
 
         itemView.setOnCreateContextMenuListener(new View.OnCreateContextMenuListener() {
             @Override
             public void onCreateContextMenu(ContextMenu menu, View view, ContextMenuInfo menuInfo) {
                 if (isPeeking()) return;
 
                 ContextMenuManager.Delegate delegate = getContextMenuDelegate();
                 if (delegate == null) return;
 
-                mNtpManager.getContextMenuManager().createContextMenu(menu, itemView, delegate);
+                contextMenuManager.createContextMenu(menu, itemView, delegate);
             }
         });
 
         mUiConfig = uiConfig;
 
         mMarginResizer = MarginResizer.createWithViewAdapter(itemView, mUiConfig);
 
         // Configure the resizer to use negative margins on regular display to balance out the
         // lateral shadow of the card 9-patch and avoid a rounded corner effect.
         mMarginResizer.setMargins(-mCards9PatchAdjustment);
-
-        mNtpManager = ntpManager;
     }
 
     /**
      * Called when the NTP cards adapter is requested to update the currently visible ViewHolder
      * with data.
      */
     @CallSuper
     protected void onBindViewHolder() {
         // Reset the peek status to avoid recycled view holders to be peeking at the wrong moment.
         if (getAdapterPosition() != mRecyclerView.getNewTabPageAdapter().getFirstCardPosition()) {
@@ skipping 159 matching lines @@
         if (hasCardAbove && hasCardBelow) return R.drawable.ntp_card_middle;
         if (!hasCardAbove && hasCardBelow) return R.drawable.ntp_card_top;
         if (hasCardAbove && !hasCardBelow) return R.drawable.ntp_card_bottom;
         return R.drawable.ntp_card_single;
     }
 
     protected NewTabPageRecyclerView getRecyclerView() {
         return mRecyclerView;
     }
 }