Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2623853002: Remove the scroll if the Reading List is empty. (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, stkhapugin, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the scroll if the Reading List is empty. BUG=678688, 680007, 680008

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm View 1 4 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-10 08:53:47 UTC) #2
Olivier
https://codereview.chromium.org/2623853002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (right): https://codereview.chromium.org/2623853002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm#newcode209 ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:209: self.collectionView.alwaysBounceVertical = NO; Should this always stay NO?
3 years, 11 months ago (2017-01-10 08:56:56 UTC) #3
gambard
Thanks, PTAL. https://codereview.chromium.org/2623853002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm (right): https://codereview.chromium.org/2623853002/diff/1/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm#newcode209 ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm:209: self.collectionView.alwaysBounceVertical = NO; On 2017/01/10 08:56:56, Olivier ...
3 years, 11 months ago (2017-01-10 09:30:38 UTC) #4
Olivier
lgtm
3 years, 11 months ago (2017-01-11 08:16:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2623853002/20001
3 years, 11 months ago (2017-01-11 08:17:19 UTC) #8
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 11 months ago (2017-01-11 10:39:46 UTC) #11
gambard
3 years, 11 months ago (2017-01-11 12:05:00 UTC) #12
Landed as 7e9f15b31cf27e8ebc5694dd417d15723c883367.
Closing this.

Powered by Google App Engine
This is Rietveld 408576698