Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 262383003: Add Intel Perceptual Computing SDK based depth video capture for Windows

Created:
6 years, 7 months ago by nhu
Modified:
6 years, 7 months ago
Reviewers:
mcasas
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add Intel Perceptual Computing SDK based depth video capture for Windows Intel Perceptual Computing SDK [1] supports to obtain depth images from depth cameras. Each pixel in depth image is a 16bits integer value which indicates the distance from an object to the camera's XY plane. When depth camera is available, VideoCaptureDevicePXCWin adds a extra "depth" camera after the "normal" ones which are backed by VideoCaptureDeviceWin or VideoCaptureDeviceMFWin. The depth value is encoded in Y plane (8bits) in YV12 image format. The 16bits to 8bits conversion is based on tone mapping [2] which aligns with the depth encoding for Tango smartphone's depth camera in VideoCaptureTango.java. Currently, this feature is behind "enable-depth-camera" flag. Tested via [3], click on GetDevices, then open "depth" camera. [1] https://software.intel.com/en-us/node/391067 [2] http://en.wikipedia.org/wiki/Tone_mapping [3] https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/peerconnection.html BUG=369849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+547 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/media.gyp View 2 chunks +9 lines, -0 lines 0 comments Download
M media/video/capture/video_capture_device.h View 1 chunk +1 line, -0 lines 0 comments Download
A media/video/capture/win/video_capture_device_pxc_win.h View 1 chunk +87 lines, -0 lines 0 comments Download
A media/video/capture/win/video_capture_device_pxc_win.cc View 1 chunk +408 lines, -0 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mcasas
drive-by from the Issue description: This looks to me like a good idea but we ...
6 years, 7 months ago (2014-05-07 11:49:21 UTC) #1
nhu
@mcasas, thanks for the suggestion. I will try the pxc_glue solution. In AVFoundation glue, some ...
6 years, 7 months ago (2014-05-08 06:59:47 UTC) #2
mcasas
6 years, 7 months ago (2014-05-08 14:00:07 UTC) #3
On 2014/05/08 06:59:47, nhu wrote:
> @mcasas, thanks for the suggestion. I will try the pxc_glue solution. 
> 
> In AVFoundation glue, some codes are from AVFoundation headers, right? If
true,
> I also need to copy some codes (symbols, structure/class definitions) from
> PCSDK's headers into the PXC library glue. I am going to check with Intel
PCSDK
> team whether there are any license concerns.

Every class coming out of AVFoundation, f.e. AVCaptureDevice, is 
wrapped with a Chrome version, i.e. CrAVCaptureDevice, which 
forwards to it [1].
The structures are indeed copied quoting where
they stem from [2].

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/media/video/captur...

Powered by Google App Engine
This is Rietveld 408576698