Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Unified Diff: net/socket/client_socket_handle.h

Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets (Closed)
Patch Set: Add NET_EXPORT_PRIVATE to fix WIN compile Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/socket/client_socket_handle.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_handle.h
diff --git a/net/socket/client_socket_handle.h b/net/socket/client_socket_handle.h
index de0381f674b90e0f61a3054ac0083f2f583f5fec..50792aa631b19b3ac43b24374cb448c4ef913d57 100644
--- a/net/socket/client_socket_handle.h
+++ b/net/socket/client_socket_handle.h
@@ -26,12 +26,6 @@
#include "net/socket/connection_attempts.h"
#include "net/socket/stream_socket.h"
-namespace base {
-namespace trace_event {
-class ProcessMemoryDump;
-}
-}
-
namespace net {
// A container for a StreamSocket.
@@ -128,10 +122,10 @@ class NET_EXPORT ClientSocketHandle {
bool GetLoadTimingInfo(bool is_reused,
LoadTimingInfo* load_timing_info) const;
- // Dumps memory allocation stats. |parent_dump_absolute_name| is the name
- // used by the parent MemoryAllocatorDump in the memory dump hierarchy.
- void DumpMemoryStats(base::trace_event::ProcessMemoryDump* pmd,
- const std::string& parent_dump_absolute_name) const;
+ // Dumps memory allocation stats into |stats|. |stats| can be assumed as being
+ // default initialized upon entry. Implementation overrides fields in
+ // |stats| and does not increment them.
eroman 2017/01/11 22:15:14 same comment here ("does not increment" is probabl
xunjieli 2017/01/11 23:19:24 Done.
+ void DumpMemoryStats(StreamSocket::SocketMemoryStats* stats) const;
// Used by ClientSocketPool to initialize the ClientSocketHandle.
//
« no previous file with comments | « no previous file | net/socket/client_socket_handle.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698