Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: net/spdy/spdy_session_pool_unittest.cc

Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets (Closed)
Patch Set: Address Eric's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_session_pool.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session_pool_unittest.cc
diff --git a/net/spdy/spdy_session_pool_unittest.cc b/net/spdy/spdy_session_pool_unittest.cc
index 6bfb95dea4e4a859376155aaa00c67cf17253394..51362da98a751a01709ac8295ec087467eb3febd 100644
--- a/net/spdy/spdy_session_pool_unittest.cc
+++ b/net/spdy/spdy_session_pool_unittest.cc
@@ -707,18 +707,20 @@ TEST_F(SpdySessionPoolTest, DumpMemoryStats) {
allocator_dumps = process_memory_dump->allocator_dumps();
for (const auto& pair : allocator_dumps) {
const std::string& dump_name = pair.first;
- if (dump_name.find("spdy_session_pool/session") == std::string::npos)
+ if (dump_name.find("spdy_session_pool") == std::string::npos)
continue;
std::unique_ptr<base::Value> raw_attrs =
pair.second->attributes_for_testing()->ToBaseValue();
base::DictionaryValue* attrs;
ASSERT_TRUE(raw_attrs->GetAsDictionary(&attrs));
- base::DictionaryValue* is_active_attrs;
- ASSERT_TRUE(attrs->GetDictionary("active", &is_active_attrs));
- std::string is_active;
- ASSERT_TRUE(is_active_attrs->GetString("value", &is_active));
+ base::DictionaryValue* active_session_count_attr;
+ ASSERT_TRUE(attrs->GetDictionary("active_session_count",
+ &active_session_count_attr));
+ std::string active_session_count;
+ ASSERT_TRUE(
+ active_session_count_attr->GetString("value", &active_session_count));
// No created stream so the session should be idle.
- ASSERT_EQ("0", is_active);
+ ASSERT_EQ("0", active_session_count);
did_dump = true;
}
EXPECT_TRUE(did_dump);
« no previous file with comments | « net/spdy/spdy_session_pool.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698