Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: net/spdy/spdy_session.h

Issue 2623803002: Avoid creating MemoryAllocatorDump for individual sockets (Closed)
Patch Set: Address Eric's comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/socket/stream_socket.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 4a4d85f95fa1a90de7d0abd7f53880b769071b2a..3ff07eef3aae028eb1c256485c194437e5cbc156 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -47,12 +47,6 @@
#include "url/gurl.h"
#include "url/scheme_host_port.h"
-namespace base {
-namespace trace_event {
-class ProcessMemoryDump;
-}
-}
-
namespace net {
namespace test {
@@ -564,10 +558,12 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// HigherLayeredPool implementation:
bool CloseOneIdleConnection() override;
- // Dumps memory allocation stats. |parent_dump_absolute_name| is the name
- // used by the parent MemoryAllocatorDump in the memory dump hierarchy.
- void DumpMemoryStats(base::trace_event::ProcessMemoryDump* pmd,
- const std::string& parent_dump_absolute_name) const;
+ // Dumps memory allocation stats to |stats|. Sets |*is_session_active| to
+ // indicate whether session is active.
+ // |stats| can be assumed as being default initialized upon entry.
+ // Implementation overrides fields in |stats|.
+ void DumpMemoryStats(StreamSocket::SocketMemoryStats* stats,
+ bool* is_session_active) const;
private:
friend class test::SpdyStreamTest;
« no previous file with comments | « net/socket/stream_socket.cc ('k') | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698